From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10550C433DF for ; Thu, 20 Aug 2020 22:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6F23207DF for ; Thu, 20 Aug 2020 22:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728115AbgHTWM4 (ORCPT ); Thu, 20 Aug 2020 18:12:56 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:49454 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728087AbgHTWM4 (ORCPT ); Thu, 20 Aug 2020 18:12:56 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k8snl-0003CQ-IM; Fri, 21 Aug 2020 08:12:54 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 21 Aug 2020 08:12:53 +1000 Date: Fri, 21 Aug 2020 08:12:53 +1000 From: Herbert Xu To: Ben Greear Cc: Ard Biesheuvel , Linux Crypto Mailing List , Eric Biggers Subject: Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher Message-ID: <20200820221253.GA24572@gondor.apana.org.au> References: <20200820072910.GA21631@gondor.apana.org.au> <20200820074414.GA21848@gondor.apana.org.au> <20200820075353.GA21901@gondor.apana.org.au> <6bd84823-7dc6-e132-2959-e73d6806d2f1@candelatech.com> <20200820201055.GA24119@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Aug 20, 2020 at 03:09:55PM -0700, Ben Greear wrote: > > I have always assumed that I need aesni instructions to have any chance at this performing well, > but there are certainly chips out there that don't have aesni, so possibly it is still worth improving > if it is relatively easy to do so. What we were discussing is the merit of improving aesni only while still being exposed to aes-generic on the softirq path. This is clearly not acceptable. Improving aes-generic obviously would make sense. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt