From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Aymen Sghaier <aymen.sghaier@nxp.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v3 PATCH] crypto: caam - Move debugfs fops into standalone file
Date: Fri, 21 Aug 2020 17:58:07 +1000 [thread overview]
Message-ID: <20200821075806.GK25143@gondor.apana.org.au> (raw)
In-Reply-To: <bf2588f8-95f0-dd10-cd03-25268ea68837@nxp.com>
On Thu, Aug 06, 2020 at 09:09:49PM +0300, Horia Geantă wrote:
>
> Currently the debugfs fops are defined in caam/intern.h. This causes
> problems because it creates identical static functions and variables
> in multiple files. It also creates warnings when those files don't
> use the fops.
>
> This patch moves them into a standalone file, debugfs.c.
>
> It also removes unnecessary uses of ifdefs on CONFIG_DEBUG_FS.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> [Moved most of debugfs-related operations into debugfs.c.]
> Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
> ---
> drivers/crypto/caam/Makefile | 2 +
> drivers/crypto/caam/ctrl.c | 77 +++------------------------
> drivers/crypto/caam/debugfs.c | 96 +++++++++++++++++++++++++++++++++++
> drivers/crypto/caam/debugfs.h | 26 ++++++++++
> drivers/crypto/caam/intern.h | 17 ------
> drivers/crypto/caam/qi.c | 20 ++------
> 6 files changed, 137 insertions(+), 102 deletions(-)
> create mode 100644 drivers/crypto/caam/debugfs.c
> create mode 100644 drivers/crypto/caam/debugfs.h
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-08-21 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 13:54 [PATCH] crypto: caam - Move debugfs fops into standalone file Herbert Xu
2020-07-31 16:46 ` Horia Geantă
2020-08-01 12:42 ` [v2 PATCH] " Herbert Xu
2020-08-06 18:09 ` [v3 " Horia Geantă
2020-08-06 22:10 ` Herbert Xu
2020-08-07 4:54 ` Herbert Xu
2020-08-21 7:58 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821075806.GK25143@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aymen.sghaier@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).