linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [cryptodev:master 2/35] drivers/crypto/stm32/stm32-crc32.c:128:2: error: implicit declaration of function 'writel_relaxed'
@ 2020-08-21 12:22 kernel test robot
  2020-08-21 12:42 ` [PATCH] crypto: stm32 - Add missing header inclusions Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-08-21 12:22 UTC (permalink / raw)
  To: Herbert Xu; +Cc: kbuild-all, clang-built-linux, linux-crypto

[-- Attachment #1: Type: text/plain, Size: 16992 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   3d29e98d1d7550fc959a7ad4258bd804b533b493
commit: 0c3dc787a62aef3ca7aedf3797ec42fff9b0a913 [2/35] crypto: algapi - Remove skbuff.h inclusion
config: arm-randconfig-r016-20200820 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b587ca93be114d07ec3bf654add97d7872325281)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        git checkout 0c3dc787a62aef3ca7aedf3797ec42fff9b0a913
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/crypto/stm32/stm32-crc32.c:128:2: error: implicit declaration of function 'writel_relaxed' [-Werror,-Wimplicit-function-declaration]
           writel_relaxed(bitrev32(mctx->key), crc->regs + CRC_INIT);
           ^
>> drivers/crypto/stm32/stm32-crc32.c:134:17: error: implicit declaration of function 'readl_relaxed' [-Werror,-Wimplicit-function-declaration]
           ctx->partial = readl_relaxed(crc->regs + CRC_DR);
                          ^
   drivers/crypto/stm32/stm32-crc32.c:134:17: note: did you mean 'writel_relaxed'?
   drivers/crypto/stm32/stm32-crc32.c:128:2: note: 'writel_relaxed' declared here
           writel_relaxed(bitrev32(mctx->key), crc->regs + CRC_INIT);
           ^
   drivers/crypto/stm32/stm32-crc32.c:166:2: error: implicit declaration of function 'writel_relaxed' [-Werror,-Wimplicit-function-declaration]
           writel_relaxed(bitrev32(ctx->partial), crc->regs + CRC_INIT);
           ^
>> drivers/crypto/stm32/stm32-crc32.c:176:4: error: implicit declaration of function 'writeb_relaxed' [-Werror,-Wimplicit-function-declaration]
                           writeb_relaxed(*d8++, crc->regs + CRC_DR);
                           ^
   drivers/crypto/stm32/stm32-crc32.c:176:4: note: did you mean 'writel_relaxed'?
   drivers/crypto/stm32/stm32-crc32.c:128:2: note: 'writel_relaxed' declared here
           writel_relaxed(bitrev32(mctx->key), crc->regs + CRC_INIT);
           ^
   drivers/crypto/stm32/stm32-crc32.c:192:4: error: implicit declaration of function 'writeb_relaxed' [-Werror,-Wimplicit-function-declaration]
                           writeb_relaxed(*d8++, crc->regs + CRC_DR);
                           ^
   drivers/crypto/stm32/stm32-crc32.c:196:17: error: implicit declaration of function 'readl_relaxed' [-Werror,-Wimplicit-function-declaration]
           ctx->partial = readl_relaxed(crc->regs + CRC_DR);
                          ^
   6 errors generated.
--
>> drivers/crypto/stm32/stm32-hash.c:492:18: error: implicit declaration of function 'dma_map_sg' [-Werror,-Wimplicit-function-declaration]
                   rctx->dma_ct = dma_map_sg(hdev->dev, &rctx->sg_key, 1,
                                  ^
>> drivers/crypto/stm32/stm32-hash.c:493:8: error: use of undeclared identifier 'DMA_TO_DEVICE'
                                             DMA_TO_DEVICE);
                                             ^
>> drivers/crypto/stm32/stm32-hash.c:501:3: error: implicit declaration of function 'dma_unmap_sg' [-Werror,-Wimplicit-function-declaration]
                   dma_unmap_sg(hdev->dev, &rctx->sg_key, 1, DMA_TO_DEVICE);
                   ^
   drivers/crypto/stm32/stm32-hash.c:501:3: note: did you mean 'dma_map_sg'?
   drivers/crypto/stm32/stm32-hash.c:492:18: note: 'dma_map_sg' declared here
                   rctx->dma_ct = dma_map_sg(hdev->dev, &rctx->sg_key, 1,
                                  ^
   drivers/crypto/stm32/stm32-hash.c:501:45: error: use of undeclared identifier 'DMA_TO_DEVICE'
                   dma_unmap_sg(hdev->dev, &rctx->sg_key, 1, DMA_TO_DEVICE);
                                                             ^
   drivers/crypto/stm32/stm32-hash.c:588:18: error: implicit declaration of function 'dma_map_sg' [-Werror,-Wimplicit-function-declaration]
                   rctx->dma_ct = dma_map_sg(hdev->dev, sg, 1,
                                  ^
   drivers/crypto/stm32/stm32-hash.c:589:8: error: use of undeclared identifier 'DMA_TO_DEVICE'
                                             DMA_TO_DEVICE);
                                             ^
   drivers/crypto/stm32/stm32-hash.c:598:3: error: implicit declaration of function 'dma_unmap_sg' [-Werror,-Wimplicit-function-declaration]
                   dma_unmap_sg(hdev->dev, sg, 1, DMA_TO_DEVICE);
                   ^
   drivers/crypto/stm32/stm32-hash.c:598:34: error: use of undeclared identifier 'DMA_TO_DEVICE'
                   dma_unmap_sg(hdev->dev, sg, 1, DMA_TO_DEVICE);
                                                  ^
   8 errors generated.

# https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=0c3dc787a62aef3ca7aedf3797ec42fff9b0a913
git remote add cryptodev https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
git fetch --no-tags cryptodev master
git checkout 0c3dc787a62aef3ca7aedf3797ec42fff9b0a913
vim +/writel_relaxed +128 drivers/crypto/stm32/stm32-crc32.c

10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  111  
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  112  static int stm32_crc_init(struct shash_desc *desc)
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  113  {
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  114  	struct stm32_crc_desc_ctx *ctx = shash_desc_ctx(desc);
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  115  	struct stm32_crc_ctx *mctx = crypto_shash_ctx(desc->tfm);
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  116  	struct stm32_crc *crc;
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  117  	unsigned long flags;
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  118  
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  119  	crc = stm32_crc_get_next_crc();
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  120  	if (!crc)
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  121  		return -ENODEV;
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  122  
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  123  	pm_runtime_get_sync(crc->dev);
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  124  
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  125  	spin_lock_irqsave(&crc->lock, flags);
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  126  
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  127  	/* Reset, set key, poly and configure in bit reverse mode */
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12 @128  	writel_relaxed(bitrev32(mctx->key), crc->regs + CRC_INIT);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  129  	writel_relaxed(bitrev32(mctx->poly), crc->regs + CRC_POL);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  130  	writel_relaxed(CRC_CR_RESET | CRC_CR_REV_IN_WORD | CRC_CR_REV_OUT,
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  131  		       crc->regs + CRC_CR);
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  132  
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  133  	/* Store partial result */
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12 @134  	ctx->partial = readl_relaxed(crc->regs + CRC_DR);
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  135  
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  136  	spin_unlock_irqrestore(&crc->lock, flags);
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  137  
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  138  	pm_runtime_mark_last_busy(crc->dev);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  139  	pm_runtime_put_autosuspend(crc->dev);
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  140  
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  141  	return 0;
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  142  }
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  143  
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  144  static int burst_update(struct shash_desc *desc, const u8 *d8,
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  145  			size_t length)
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  146  {
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  147  	struct stm32_crc_desc_ctx *ctx = shash_desc_ctx(desc);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  148  	struct stm32_crc_ctx *mctx = crypto_shash_ctx(desc->tfm);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  149  	struct stm32_crc *crc;
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  150  	unsigned long flags;
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  151  
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  152  	crc = stm32_crc_get_next_crc();
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  153  	if (!crc)
10b89c43a64eb0d drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  154  		return -ENODEV;
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  155  
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  156  	pm_runtime_get_sync(crc->dev);
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  157  
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  158  	spin_lock_irqsave(&crc->lock, flags);
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  159  
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  160  	/*
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  161  	 * Restore previously calculated CRC for this context as init value
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  162  	 * Restore polynomial configuration
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  163  	 * Configure in register for word input data,
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  164  	 * Configure out register in reversed bit mode data.
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  165  	 */
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  166  	writel_relaxed(bitrev32(ctx->partial), crc->regs + CRC_INIT);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  167  	writel_relaxed(bitrev32(mctx->poly), crc->regs + CRC_POL);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  168  	writel_relaxed(CRC_CR_RESET | CRC_CR_REV_IN_WORD | CRC_CR_REV_OUT,
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  169  		       crc->regs + CRC_CR);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  170  
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  171  	if (d8 != PTR_ALIGN(d8, sizeof(u32))) {
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  172  		/* Configure for byte data */
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  173  		writel_relaxed(CRC_CR_REV_IN_BYTE | CRC_CR_REV_OUT,
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  174  			       crc->regs + CRC_CR);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  175  		while (d8 != PTR_ALIGN(d8, sizeof(u32)) && length) {
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12 @176  			writeb_relaxed(*d8++, crc->regs + CRC_DR);
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  177  			length--;
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  178  		}
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  179  		/* Configure for word data */
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  180  		writel_relaxed(CRC_CR_REV_IN_WORD | CRC_CR_REV_OUT,
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  181  			       crc->regs + CRC_CR);
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  182  	}
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  183  
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  184  	for (; length >= sizeof(u32); d8 += sizeof(u32), length -= sizeof(u32))
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  185  		writel_relaxed(*((u32 *)d8), crc->regs + CRC_DR);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  186  
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  187  	if (length) {
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  188  		/* Configure for byte data */
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  189  		writel_relaxed(CRC_CR_REV_IN_BYTE | CRC_CR_REV_OUT,
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  190  			       crc->regs + CRC_CR);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  191  		while (length--)
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  192  			writeb_relaxed(*d8++, crc->regs + CRC_DR);
49c2c082e00e0bc drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  193  	}
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  194  
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  195  	/* Store partial result */
391775191f38f80 drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2017-07-13  196  	ctx->partial = readl_relaxed(crc->regs + CRC_DR);
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  197  
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  198  	spin_unlock_irqrestore(&crc->lock, flags);
7795c0baf5ac25e drivers/crypto/stm32/stm32-crc32.c Nicolas Toromanoff    2020-05-12  199  
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  200  	pm_runtime_mark_last_busy(crc->dev);
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  201  	pm_runtime_put_autosuspend(crc->dev);
73463ade0a57d2c drivers/crypto/stm32/stm32_crc32.c lionel.debieve@st.com 2018-06-26  202  
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  203  	return 0;
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  204  }
b51dbe90912a0ce drivers/crypto/stm32/stm32_crc32.c Fabien DESSENNE       2017-03-21  205  

:::::: The code at line 128 was first introduced by commit
:::::: 49c2c082e00e0bc4f5cbb7c21c7f0f873b35ab09 crypto: stm32/crc32 - fix ext4 chksum BUG_ON()

:::::: TO: Nicolas Toromanoff <nicolas.toromanoff@st.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26549 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] crypto: stm32 - Add missing header inclusions
  2020-08-21 12:22 [cryptodev:master 2/35] drivers/crypto/stm32/stm32-crc32.c:128:2: error: implicit declaration of function 'writel_relaxed' kernel test robot
@ 2020-08-21 12:42 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2020-08-21 12:42 UTC (permalink / raw)
  To: kernel test robot; +Cc: kbuild-all, clang-built-linux, linux-crypto

On Fri, Aug 21, 2020 at 08:22:37PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   3d29e98d1d7550fc959a7ad4258bd804b533b493
> commit: 0c3dc787a62aef3ca7aedf3797ec42fff9b0a913 [2/35] crypto: algapi - Remove skbuff.h inclusion
> config: arm-randconfig-r016-20200820 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b587ca93be114d07ec3bf654add97d7872325281)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm cross compiling tool for clang build
>         # apt-get install binutils-arm-linux-gnueabi
>         git checkout 0c3dc787a62aef3ca7aedf3797ec42fff9b0a913
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>

Thanks for the report.  This patch should fix it:

---8<---
The stm32 driver was missing a number of includes that we being
pulled in by unrelated header files.  As the indirect inclusion
went away, it now fails to build.

This patch adds the missing inclusions.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 0c3dc787a62a ("crypto: algapi - Remove skbuff.h inclusion")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c
index 3ba41148c2a4..5fb706b68309 100644
--- a/drivers/crypto/stm32/stm32-crc32.c
+++ b/drivers/crypto/stm32/stm32-crc32.c
@@ -7,6 +7,8 @@
 #include <linux/bitrev.h>
 #include <linux/clk.h>
 #include <linux/crc32poly.h>
+#include <linux/io.h>
+#include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index 03c5e6683805..092eaabda238 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -9,6 +9,7 @@
 #include <linux/clk.h>
 #include <linux/crypto.h>
 #include <linux/delay.h>
+#include <linux/dma-mapping.h>
 #include <linux/dmaengine.h>
 #include <linux/interrupt.h>
 #include <linux/io.h>
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-21 12:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21 12:22 [cryptodev:master 2/35] drivers/crypto/stm32/stm32-crc32.c:128:2: error: implicit declaration of function 'writel_relaxed' kernel test robot
2020-08-21 12:42 ` [PATCH] crypto: stm32 - Add missing header inclusions Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).