linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h>
@ 2020-08-24 13:58 Fabio Estevam
  2020-08-24 13:58 ` [PATCH 2/2] crypto: stm32/hash - include <linux/dma-mapping.h> Fabio Estevam
  2020-08-25  0:43 ` [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h> Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-08-24 13:58 UTC (permalink / raw)
  To: herbert; +Cc: linux-crypto, linux-stm32, mcoquelin.stm32, Fabio Estevam

Building ARM allmodconfig leads to the following warnings:

drivers/crypto/stm32/stm32-crc32.c:128:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
drivers/crypto/stm32/stm32-crc32.c:134:17: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
drivers/crypto/stm32/stm32-crc32.c:176:4: error: implicit declaration of function 'writeb_relaxed' [-Werror=implicit-function-declaration]

Include <linux/io.h> to fix such warnings.

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/crypto/stm32/stm32-crc32.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c
index 3ba41148c2a4..2994549beba3 100644
--- a/drivers/crypto/stm32/stm32-crc32.c
+++ b/drivers/crypto/stm32/stm32-crc32.c
@@ -7,6 +7,7 @@
 #include <linux/bitrev.h>
 #include <linux/clk.h>
 #include <linux/crc32poly.h>
+#include <linux/io.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] crypto: stm32/hash - include <linux/dma-mapping.h>
  2020-08-24 13:58 [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h> Fabio Estevam
@ 2020-08-24 13:58 ` Fabio Estevam
  2020-08-25  0:43 ` [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h> Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2020-08-24 13:58 UTC (permalink / raw)
  To: herbert; +Cc: linux-crypto, linux-stm32, mcoquelin.stm32, Fabio Estevam

Building ARM allmodconfig leads to the following warnings:

drivers/crypto/stm32/stm32-hash.c:492:18: error: implicit declaration of function 'dma_map_sg'; did you mean 'dma_cap_set'? [-Werror=implicit-function-declaration]
drivers/crypto/stm32/stm32-hash.c:493:8: error: 'DMA_TO_DEVICE' undeclared (first use in this function); did you mean 'MT_DEVICE'?
drivers/crypto/stm32/stm32-hash.c:501:3: error: implicit declaration of function 'dma_unmap_sg' [-Werror=implicit-function-declaration]
drivers/crypto/stm32/stm32-hash.c:589:8: error: 'DMA_TO_DEVICE' undeclared (first use in this function); did you mean 'MT_DEVICE'?

Include <linux/dma-mapping.h> to fix such warnings

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/crypto/stm32/stm32-hash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index 03c5e6683805..092eaabda238 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -9,6 +9,7 @@
 #include <linux/clk.h>
 #include <linux/crypto.h>
 #include <linux/delay.h>
+#include <linux/dma-mapping.h>
 #include <linux/dmaengine.h>
 #include <linux/interrupt.h>
 #include <linux/io.h>
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h>
  2020-08-24 13:58 [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h> Fabio Estevam
  2020-08-24 13:58 ` [PATCH 2/2] crypto: stm32/hash - include <linux/dma-mapping.h> Fabio Estevam
@ 2020-08-25  0:43 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-08-25  0:43 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-crypto, linux-stm32, mcoquelin.stm32

On Mon, Aug 24, 2020 at 10:58:39AM -0300, Fabio Estevam wrote:
> Building ARM allmodconfig leads to the following warnings:
> 
> drivers/crypto/stm32/stm32-crc32.c:128:2: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
> drivers/crypto/stm32/stm32-crc32.c:134:17: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
> drivers/crypto/stm32/stm32-crc32.c:176:4: error: implicit declaration of function 'writeb_relaxed' [-Werror=implicit-function-declaration]
> 
> Include <linux/io.h> to fix such warnings.
> 
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  drivers/crypto/stm32/stm32-crc32.c | 1 +
>  1 file changed, 1 insertion(+)

Thank you.  But this is already in the queue:

https://patchwork.kernel.org/patch/11729369/
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-25  0:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 13:58 [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h> Fabio Estevam
2020-08-24 13:58 ` [PATCH 2/2] crypto: stm32/hash - include <linux/dma-mapping.h> Fabio Estevam
2020-08-25  0:43 ` [PATCH 1/2] crypto: stm32/crc32 - include <linux/io.h> Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).