From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BAFC433DF for ; Wed, 26 Aug 2020 11:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA2F12080C for ; Wed, 26 Aug 2020 11:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728823AbgHZLuS (ORCPT ); Wed, 26 Aug 2020 07:50:18 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:33050 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728802AbgHZLuR (ORCPT ); Wed, 26 Aug 2020 07:50:17 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kAtw8-0002Yd-HZ; Wed, 26 Aug 2020 21:49:53 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 26 Aug 2020 21:49:52 +1000 Date: Wed, 26 Aug 2020 21:49:52 +1000 From: Herbert Xu To: Ard Biesheuvel Cc: Paul Menzel , Caleb Jorden , Sasha Levin , iwd@lists.01.org, "# 3.4.x" , Greg KH , LKML , "David S. Miller" , Linux Crypto Mailing List Subject: Re: Issue with iwd + Linux 5.8.3 + WPA Enterprise Message-ID: <20200826114952.GA2375@gondor.apana.org.au> References: <20200826055150.2753.90553@ml01.vlan13.01.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Aug 26, 2020 at 12:40:14PM +0200, Ard Biesheuvel wrote: > > It would be helpful if someone could explain for the non-mac80211 > enlightened readers how iwd's EAP-PEAPv0 + MSCHAPv2 support relies on > the algif_aead socket interface, and which AEAD algorithms it uses. I > assume this is part of libell? I see the problem. libell/ell/checksum.c doesn't clear the MSG_MORE flag before doing the recv(2). I was hoping nobody out there was doing this but obviously I've been proven wrong. So what I'm going to do is to specifically allow this case of a string of sendmsg(2)'s with MSG_MORE folloed by a recvmsg(2) in the same thread. I'll add a WARN_ON_ONCE so user-space can eventually be fixed. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt