From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
qat-linux <qat-linux@intel.com>,
"Przychodni, Dominik" <dominik.przychodni@intel.com>
Subject: Re: [PATCH] crypto: qat - aead cipher length should be block multiple
Date: Fri, 28 Aug 2020 10:23:59 +0100 [thread overview]
Message-ID: <20200828092359.GA62902@silpixa00400314> (raw)
In-Reply-To: <1cffce42de2f4e7b84514a27bd9a889d@irsmsx602.ger.corp.intel.com>
On Sat, Aug 22, 2020 at 02:04:10PM +0100, Ard Biesheuvel wrote:
> On Sat, 22 Aug 2020 at 09:29, Giovanni Cabiddu
> <giovanni.cabiddu@intel.com> wrote:
> >
> > From: Dominik Przychodni <dominik.przychodni@intel.com>
> >
> > Include an additional check on the cipher length to prevent undefined
> > behaviour from occurring upon submitting requests which are not a
> > multiple of AES_BLOCK_SIZE.
> >
> > Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface")
> > Signed-off-by: Dominik Przychodni <dominik.przychodni@intel.com>
> > Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
>
> I only looked at the patch, and not at the entire file, but could you
> explain which AES based AEAD implementations require the input length
> to be a multiple of the block size? CCM and GCM are both CTR based,
> and so any input length should be supported for at least those modes.
This is only for AES CBC as the qat driver supports only
authenc(hmac(sha1),cbc(aes)), authenc(hmac(sha256),cbc(aes)) and
authenc(hmac(sha512),cbc(aes)).
Regards,
--
Giovanni
next prev parent reply other threads:[~2020-08-28 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 7:29 [PATCH] crypto: qat - aead cipher length should be block multiple Giovanni Cabiddu
2020-08-22 13:04 ` Ard Biesheuvel
[not found] ` <1cffce42de2f4e7b84514a27bd9a889d@irsmsx602.ger.corp.intel.com>
2020-08-28 9:23 ` Giovanni Cabiddu [this message]
2020-08-31 13:26 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828092359.GA62902@silpixa00400314 \
--to=giovanni.cabiddu@intel.com \
--cc=ardb@kernel.org \
--cc=dominik.przychodni@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).