From: Maxime Ripard <maxime@cerno.tech>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
robh+dt@kernel.org, robh@kernel.org, wens@csie.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com, m.cerveny@computer.org
Subject: Re: [PATCH] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset
Date: Wed, 2 Sep 2020 15:24:34 +0200 [thread overview]
Message-ID: <20200902132434.qpevlbyx5wgq4daj@gilmour.lan> (raw)
In-Reply-To: <20200902091716.22650-1-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
On Wed, Sep 02, 2020 at 11:17:16AM +0200, Corentin Labbe wrote:
> When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset.
> Furthermore, there are no need to use items to list only one compatible
> in compatible list.
>
> Fixes: f81547ba7a98 ("dt-bindings: crypto: add new compatible for A33 SS")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> index fc823572bcff..1075f0e75368 100644
> --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
> @@ -23,8 +23,7 @@ properties:
> - items:
> - const: allwinner,sun7i-a20-crypto
> - const: allwinner,sun4i-a10-crypto
> - - items:
> - - const: allwinner,sun8i-a33-crypto
> + - const: allwinner,sun8i-a33-crypto
>
> reg:
> maxItems: 1
> @@ -59,7 +58,9 @@ if:
> properties:
> compatible:
> contains:
> - const: allwinner,sun6i-a31-crypto
> + oneOf:
> + - const: allwinner,sun6i-a31-crypto
> + - const: allwinner,sun8i-a33-crypto
Even though it works, an enum would be best here
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2020-09-02 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 9:17 [PATCH] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset Corentin Labbe
2020-09-02 13:24 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902132434.qpevlbyx5wgq4daj@gilmour.lan \
--to=maxime@cerno.tech \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=m.cerveny@computer.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).