From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54B3C43461 for ; Fri, 4 Sep 2020 13:51:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2E1F2078E for ; Fri, 4 Sep 2020 13:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730528AbgIDNv1 (ORCPT ); Fri, 4 Sep 2020 09:51:27 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:43100 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730569AbgIDNuw (ORCPT ); Fri, 4 Sep 2020 09:50:52 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kEC72-0007X0-Ah; Fri, 04 Sep 2020 23:50:45 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Sep 2020 23:50:44 +1000 Date: Fri, 4 Sep 2020 23:50:44 +1000 From: Herbert Xu To: Srujana Challa Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-crypto@vger.kernel.org" , Suheil Chandran , Narayana Prasad Raju Athreya , Sunil Kovvuri Goutham , Linu Cherian , Geethasowjanya Akula , Jerin Jacob Kollanukkaran , Ard Biesheuvel Subject: Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine Message-ID: <20200904135044.GA2836@gondor.apana.org.au> References: <1596809360-12597-1-git-send-email-schalla@marvell.com> <1596809360-12597-3-git-send-email-schalla@marvell.com> <20200813005407.GB24593@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Sep 04, 2020 at 01:45:38PM +0000, Srujana Challa wrote: > > This block of code is used for LMT store operations. The LMT store operation > is specific to our platform, and this uses the "ldeor" instruction(which is > actually an LSE atomic instruction available on v8.1 CPUs) targeting the > IO address. > We add it in the driver since we want LMT store to work even if LSE_ATOMICS > is disabled. You have exactly the same macro in your net driver. Move it into a header file in arch/arm64/include/asm and also add one under include/asm-generic so we can compile-test. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt