From: Herbert Xu <herbert@gondor.apana.org.au>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
Dominik Przychodni <dominik.przychodni@intel.com>
Subject: Re: [PATCH v2] crypto: qat - check cipher length for aead AES-CBC-HMAC-SHA
Date: Fri, 11 Sep 2020 16:57:32 +1000 [thread overview]
Message-ID: <20200911065732.GD32150@gondor.apana.org.au> (raw)
In-Reply-To: <20200831105959.107261-1-giovanni.cabiddu@intel.com>
On Mon, Aug 31, 2020 at 11:59:59AM +0100, Giovanni Cabiddu wrote:
> From: Dominik Przychodni <dominik.przychodni@intel.com>
>
> Return -EINVAL for authenc(hmac(sha1),cbc(aes)),
> authenc(hmac(sha256),cbc(aes)) and authenc(hmac(sha512),cbc(aes))
> if the cipher length is not multiple of the AES block.
> This is to prevent an undefined device behaviour.
>
> Fixes: d370cec32194 ("crypto: qat - Intel(R) QAT crypto interface")
> Signed-off-by: Dominik Przychodni <dominik.przychodni@intel.com>
> [giovanni.cabiddu@intel.com: reworded commit message]
> Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/qat/qat_common/qat_algs.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-09-11 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:59 [PATCH v2] crypto: qat - check cipher length for aead AES-CBC-HMAC-SHA Giovanni Cabiddu
2020-09-11 6:57 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911065732.GD32150@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dominik.przychodni@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).