From: Christoph Hellwig <hch@infradead.org>
To: Nick Terrell <terrelln@fb.com>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>,
Nick Terrell <nickrterrell@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
"squashfs-devel@lists.sourceforge.net"
<squashfs-devel@lists.sourceforge.net>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>, Chris Mason <clm@fb.com>,
Petr Malat <oss@malat.biz>, Johannes Weiner <jweiner@fb.com>,
Niket Agarwal <niketa@fb.com>, Yann Collet <cyan@fb.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [GIT PULL][PATCH v4 0/9] Update to zstd-1.4.6
Date: Fri, 2 Oct 2020 07:56:25 +0100 [thread overview]
Message-ID: <20201002065625.GB29993@infradead.org> (raw)
In-Reply-To: <D369584C-5BA4-4C08-BFE9-8DB79A05CC31@fb.com>
On Thu, Oct 01, 2020 at 06:35:34PM +0000, Nick Terrell wrote:
> I???m open to suggestions on how to get a zstd update done better. I don???t
> know of any way to break this patch up into smaller patches that all compile.
> The code is all generated directly from upstream and modified to work in the
> kernel by automated scripts.
Documentation/process/submitting-patches.rst:
"Separate your changes
---------------------
Separate each **logical change** into a separate patch.
For example, if your changes include both bug fixes and performance
enhancements for a single driver, separate those changes into two
or more patches. If your changes include an API update, and a new
driver which uses that new API, separate those into two patches."
It's not that hard, is it? Please do your very basic homework instead
of pretending to be a special snowflake and then come back.
prev parent reply other threads:[~2020-10-02 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:53 [PATCH v4 0/9] Update to zstd-1.4.6 Nick Terrell
2020-09-30 6:53 ` [PATCH v4 1/9] lib: zstd: Add zstd compatibility wrapper Nick Terrell
2020-09-30 6:53 ` [PATCH v4 2/9] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2020-09-30 6:53 ` [PATCH v4 4/9] crypto: zstd: Switch to zstd-1.4.6 API Nick Terrell
2020-09-30 6:53 ` [PATCH v4 5/9] btrfs: zstd: Switch to the " Nick Terrell
2020-09-30 6:53 ` [PATCH v4 6/9] f2fs: " Nick Terrell
2020-09-30 6:53 ` [PATCH v4 7/9] squashfs: " Nick Terrell
2020-09-30 6:53 ` [PATCH v4 8/9] lib: unzstd: " Nick Terrell
2020-09-30 6:53 ` [PATCH v4 9/9] lib: zstd: Remove zstd compatibility wrapper Nick Terrell
2020-09-30 6:53 ` [PATCH v4 0/9] Update to zstd-1.4.6 Christoph Hellwig
2020-09-30 20:05 ` Nick Terrell
2020-10-02 6:54 ` Christoph Hellwig
2020-10-02 13:42 ` Chris Mason
2020-09-30 20:49 ` [GIT PULL][PATCH " Nick Terrell
2020-10-01 10:18 ` David Sterba
2020-10-01 18:35 ` Nick Terrell
2020-10-02 6:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002065625.GB29993@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=cyan@fb.com \
--cc=dsterba@suse.cz \
--cc=herbert@gondor.apana.org.au \
--cc=jweiner@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickrterrell@gmail.com \
--cc=niketa@fb.com \
--cc=oss@malat.biz \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).