From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FCAC433E6 for ; Sat, 2 Jan 2021 22:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D090207A5 for ; Sat, 2 Jan 2021 22:10:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbhABWJr (ORCPT ); Sat, 2 Jan 2021 17:09:47 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:37410 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbhABWJr (ORCPT ); Sat, 2 Jan 2021 17:09:47 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kvp4y-0000mU-9W; Sun, 03 Jan 2021 09:08:57 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sun, 03 Jan 2021 09:08:56 +1100 Date: Sun, 3 Jan 2021 09:08:56 +1100 From: Herbert Xu To: Christophe JAILLET Cc: mpm@selenic.com, zhouyanjie@wanyeetech.com, aric.pzqi@ingenic.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] hwrng: ingenic - Fix a resource leak in an error handling path Message-ID: <20210102220856.GQ12767@gondor.apana.org.au> References: <20201219075207.176279-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201219075207.176279-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Dec 19, 2020 at 08:52:07AM +0100, Christophe JAILLET wrote: > In case of error, we should call 'clk_disable_unprepare()' to undo a > previous 'clk_prepare_enable()' call, as already done in the remove > function. > > Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830") > Signed-off-by: Christophe JAILLET > --- > drivers/char/hw_random/ingenic-trng.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt