linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function
@ 2021-01-15 17:17 Jason A. Donenfeld
  2021-01-15 17:25 ` Ard Biesheuvel
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Jason A. Donenfeld @ 2021-01-15 17:17 UTC (permalink / raw)
  To: linux-crypto, ardb, herbert; +Cc: Jason A. Donenfeld, John Donnelly

With no mod_exit function, users are unable to load the module after
use. I'm not aware of any reason why module unloading should be
prohibited for this one, so this commit simply adds an empty exit
function.

Reported-by: John Donnelly <john.p.donnelly@oracle.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 lib/crypto/chacha20poly1305.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
index 5850f3b87359..c2fcdb98cc02 100644
--- a/lib/crypto/chacha20poly1305.c
+++ b/lib/crypto/chacha20poly1305.c
@@ -362,7 +362,12 @@ static int __init mod_init(void)
 	return 0;
 }
 
+static void __exit mod_exit(void)
+{
+}
+
 module_init(mod_init);
+module_exit(mod_exit);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
 MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-15 17:17 [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function Jason A. Donenfeld
@ 2021-01-15 17:25 ` Ard Biesheuvel
  2021-01-15 17:44 ` Eric Biggers
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Ard Biesheuvel @ 2021-01-15 17:25 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: Linux Crypto Mailing List, Herbert Xu, John Donnelly

On Fri, 15 Jan 2021 at 18:17, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> With no mod_exit function, users are unable to load the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
>
> Reported-by: John Donnelly <john.p.donnelly@oracle.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  lib/crypto/chacha20poly1305.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
> index 5850f3b87359..c2fcdb98cc02 100644
> --- a/lib/crypto/chacha20poly1305.c
> +++ b/lib/crypto/chacha20poly1305.c
> @@ -362,7 +362,12 @@ static int __init mod_init(void)
>         return 0;
>  }
>
> +static void __exit mod_exit(void)
> +{
> +}
> +
>  module_init(mod_init);
> +module_exit(mod_exit);
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
>  MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
> --
> 2.30.0
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-15 17:17 [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function Jason A. Donenfeld
  2021-01-15 17:25 ` Ard Biesheuvel
@ 2021-01-15 17:44 ` Eric Biggers
  2021-01-15 18:06 ` John Donnelly
  2021-01-15 19:30 ` [PATCH v2] " Jason A. Donenfeld
  3 siblings, 0 replies; 8+ messages in thread
From: Eric Biggers @ 2021-01-15 17:44 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: linux-crypto, ardb, herbert, John Donnelly

On Fri, Jan 15, 2021 at 06:17:43PM +0100, Jason A. Donenfeld wrote:
> users are unable to load the module after use.

It should say "unload".

- Eric

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-15 17:17 [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function Jason A. Donenfeld
  2021-01-15 17:25 ` Ard Biesheuvel
  2021-01-15 17:44 ` Eric Biggers
@ 2021-01-15 18:06 ` John Donnelly
  2021-01-15 19:30 ` [PATCH v2] " Jason A. Donenfeld
  3 siblings, 0 replies; 8+ messages in thread
From: John Donnelly @ 2021-01-15 18:06 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: linux-crypto, ardb, herbert



> On Jan 15, 2021, at 11:17 AM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> 
> With no mod_exit function, users are unable to load the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
> 
> Reported-by: John Donnelly <john.p.donnelly@oracle.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---


Hi ,

 Verified 

 Please add 


  Test-by: John Donnelly <john.p.donnelly@oracle.com>



> lib/crypto/chacha20poly1305.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
> index 5850f3b87359..c2fcdb98cc02 100644
> --- a/lib/crypto/chacha20poly1305.c
> +++ b/lib/crypto/chacha20poly1305.c
> @@ -362,7 +362,12 @@ static int __init mod_init(void)
> 	return 0;
> }
> 
> +static void __exit mod_exit(void)
> +{
> +}
> +
> module_init(mod_init);
> +module_exit(mod_exit);
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
> MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
> -- 
> 2.30.0
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-15 17:17 [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function Jason A. Donenfeld
                   ` (2 preceding siblings ...)
  2021-01-15 18:06 ` John Donnelly
@ 2021-01-15 19:30 ` Jason A. Donenfeld
  2021-01-16  0:28   ` John Donnelly
  2021-01-22  6:21   ` Herbert Xu
  3 siblings, 2 replies; 8+ messages in thread
From: Jason A. Donenfeld @ 2021-01-15 19:30 UTC (permalink / raw)
  To: linux-crypto, ardb, herbert; +Cc: Jason A. Donenfeld, John Donnelly

With no mod_exit function, users are unable to unload the module after
use. I'm not aware of any reason why module unloading should be
prohibited for this one, so this commit simply adds an empty exit
function.

Reported-and-tested-by: John Donnelly <john.p.donnelly@oracle.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
v1->v2:
- Fix typo in commit message.

 lib/crypto/chacha20poly1305.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
index 5850f3b87359..c2fcdb98cc02 100644
--- a/lib/crypto/chacha20poly1305.c
+++ b/lib/crypto/chacha20poly1305.c
@@ -362,7 +362,12 @@ static int __init mod_init(void)
 	return 0;
 }
 
+static void __exit mod_exit(void)
+{
+}
+
 module_init(mod_init);
+module_exit(mod_exit);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
 MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-15 19:30 ` [PATCH v2] " Jason A. Donenfeld
@ 2021-01-16  0:28   ` John Donnelly
  2021-01-16  0:31     ` Jason A. Donenfeld
  2021-01-22  6:21   ` Herbert Xu
  1 sibling, 1 reply; 8+ messages in thread
From: John Donnelly @ 2021-01-16  0:28 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: linux-crypto, ardb, herbert



> On Jan 15, 2021, at 1:30 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> 
> With no mod_exit function, users are unable to unload the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
> 
> Reported-and-tested-by: John Donnelly <john.p.donnelly@oracle.com>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Thanks! 

Would someone be kind enough to remind when this appears and I will apply it to our product ? We like to use published commits when possible.

JD


> ---
> v1->v2:
> - Fix typo in commit message.
> 
> lib/crypto/chacha20poly1305.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
> index 5850f3b87359..c2fcdb98cc02 100644
> --- a/lib/crypto/chacha20poly1305.c
> +++ b/lib/crypto/chacha20poly1305.c
> @@ -362,7 +362,12 @@ static int __init mod_init(void)
> 	return 0;
> }
> 
> +static void __exit mod_exit(void)
> +{
> +}
> +
> module_init(mod_init);
> +module_exit(mod_exit);
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
> MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
> -- 
> 2.30.0
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-16  0:28   ` John Donnelly
@ 2021-01-16  0:31     ` Jason A. Donenfeld
  0 siblings, 0 replies; 8+ messages in thread
From: Jason A. Donenfeld @ 2021-01-16  0:31 UTC (permalink / raw)
  To: John Donnelly; +Cc: Linux Crypto Mailing List, Ard Biesheuvel, Herbert Xu

On Sat, Jan 16, 2021 at 1:30 AM John Donnelly
<john.p.donnelly@oracle.com> wrote:
>
>
>
> > On Jan 15, 2021, at 1:30 PM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >
> > With no mod_exit function, users are unable to unload the module after
> > use. I'm not aware of any reason why module unloading should be
> > prohibited for this one, so this commit simply adds an empty exit
> > function.
> >
> > Reported-and-tested-by: John Donnelly <john.p.donnelly@oracle.com>
> > Acked-by: Ard Biesheuvel <ardb@kernel.org>
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Thanks!
>
> Would someone be kind enough to remind when this appears and I will apply it to our product ? We like to use published commits when possible.
>
> JD

It'll show up in one of these two repos in a week or two:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git/
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function
  2021-01-15 19:30 ` [PATCH v2] " Jason A. Donenfeld
  2021-01-16  0:28   ` John Donnelly
@ 2021-01-22  6:21   ` Herbert Xu
  1 sibling, 0 replies; 8+ messages in thread
From: Herbert Xu @ 2021-01-22  6:21 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: linux-crypto, ardb, John Donnelly

On Fri, Jan 15, 2021 at 08:30:12PM +0100, Jason A. Donenfeld wrote:
> With no mod_exit function, users are unable to unload the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
> 
> Reported-and-tested-by: John Donnelly <john.p.donnelly@oracle.com>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> v1->v2:
> - Fix typo in commit message.
> 
>  lib/crypto/chacha20poly1305.c | 5 +++++
>  1 file changed, 5 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-01-22  6:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 17:17 [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function Jason A. Donenfeld
2021-01-15 17:25 ` Ard Biesheuvel
2021-01-15 17:44 ` Eric Biggers
2021-01-15 18:06 ` John Donnelly
2021-01-15 19:30 ` [PATCH v2] " Jason A. Donenfeld
2021-01-16  0:28   ` John Donnelly
2021-01-16  0:31     ` Jason A. Donenfeld
2021-01-22  6:21   ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).