From: Vitaly Chikunov <vt@altlinux.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stefan Berger <stefanb@linux.ibm.com>,
Ard Biesheuvel <ardb@kernel.org>, Meng Yu <yumeng18@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Zaibo Xu <xuzaibo@huawei.com>,
wangzhou1@hisilicon.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Daniele Alessandrelli <daniele.alessandrelli@linux.intel.com>,
Mark Gross <mgross@linux.intel.com>,
"Khurana, Prabhjot" <prabhjot.khurana@intel.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
Patrick Uiterwijk <patrick@puiterwijk.org>
Subject: Re: [PATCH v7 4/7] crypto: add ecc curve and expose them
Date: Mon, 8 Feb 2021 09:35:41 +0300 [thread overview]
Message-ID: <20210208063541.ribifj3445djxfy5@altlinux.org> (raw)
In-Reply-To: <20210129030004.GA3463@gondor.apana.org.au>
Herbert,
On Fri, Jan 29, 2021 at 02:00:04PM +1100, Herbert Xu wrote:
> On Thu, Jan 28, 2021 at 09:49:41PM -0500, Stefan Berger wrote:
> >
> > In my patch series I initially had registered the akciphers under the names
> > ecc-nist-p192 and ecc-nist-p256 but now, in V4, joined them together as
> > 'ecdsa'. This may be too generic for a name. Maybe it should be called
> > ecsda-nist for the NIST family.
>
> What I'm proposing is specifying the curve in the name as well, i.e.,
> ecdsa-nist-p192 instead of just ecdsa or ecdsa-nist.
>
> This simplifies the task of handling hardware that only supports a
> subset of curves.
So, if some implementation supports multiple curves (like EC-RDSA
currently supports 5 curves), it should add 5 ecrdsa-{a,b,c,..}
algorithms with actually the same top level implementation?
Right?
> There is a parallel discussion of exactly what curves we should
> support in the kernel. Personally if there is a user in the kernel
> for it then I'm happy to see it added. In your specific case, as
> long as your use of the algorithm in x509 is accepted then I don't
> have any problems with adding support in the Crypto API.
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-02-08 6:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 7:09 [PATCH v7 0/7] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Meng Yu
2021-01-22 7:09 ` [PATCH v7 1/7] crypto: hisilicon/hpre - add version adapt to new algorithms Meng Yu
2021-01-22 7:09 ` [PATCH v7 2/7] crypto: hisilicon/hpre - add some updates to adapt to Kunpeng 930 Meng Yu
2021-01-22 7:09 ` [PATCH v7 3/7] crypto: hisilicon/hpre - add algorithm type Meng Yu
2021-01-22 7:09 ` [PATCH v7 4/7] crypto: add ecc curve and expose them Meng Yu
2021-01-28 5:03 ` Herbert Xu
2021-01-28 10:30 ` Ard Biesheuvel
2021-01-28 10:39 ` Herbert Xu
2021-02-01 17:09 ` Daniele Alessandrelli
2021-02-02 5:13 ` Herbert Xu
2021-02-02 9:27 ` Alessandrelli, Daniele
2021-02-02 9:42 ` Herbert Xu
2021-02-02 12:35 ` Alessandrelli, Daniele
2021-02-04 5:31 ` Herbert Xu
2021-01-29 2:49 ` Stefan Berger
2021-01-29 3:00 ` Herbert Xu
2021-02-08 6:35 ` Vitaly Chikunov [this message]
2021-02-08 6:47 ` Ard Biesheuvel
2021-02-08 21:27 ` Vitaly Chikunov
2021-02-01 3:45 ` yumeng
2021-02-03 18:03 ` Saulo Alessandre
2021-02-04 5:41 ` Herbert Xu
2021-01-22 7:09 ` [PATCH v7 5/7] crypto: add curve 25519 " Meng Yu
2021-01-22 7:09 ` [PATCH v7 6/7] crypto: hisilicon/hpre - add 'ECDH' algorithm Meng Yu
2021-01-22 7:09 ` [PATCH v7 7/7] crypto: hisilicon/hpre - add 'CURVE25519' algorithm Meng Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208063541.ribifj3445djxfy5@altlinux.org \
--to=vt@altlinux.org \
--cc=ardb@kernel.org \
--cc=daniele.alessandrelli@linux.intel.com \
--cc=davem@davemloft.net \
--cc=elena.reshetova@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=patrick@puiterwijk.org \
--cc=prabhjot.khurana@intel.com \
--cc=stefanb@linux.ibm.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=yumeng18@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).