From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC08C433DB for ; Fri, 12 Mar 2021 13:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0D2B64FDC for ; Fri, 12 Mar 2021 13:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230447AbhCLM7u (ORCPT ); Fri, 12 Mar 2021 07:59:50 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:54334 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbhCLM7i (ORCPT ); Fri, 12 Mar 2021 07:59:38 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lKhNu-0005xD-BK; Fri, 12 Mar 2021 23:59:19 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 12 Mar 2021 23:59:18 +1100 Date: Fri, 12 Mar 2021 23:59:18 +1100 From: Herbert Xu To: Longfang Liu Cc: wangzhou1@hisilicon.com, xuzaibo@huawei.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] crypto: hisilicon/sec - fixes some log printing style Message-ID: <20210312125918.GA12149@gondor.apana.org.au> References: <1614838735-52668-1-git-send-email-liulongfang@huawei.com> <1614838735-52668-2-git-send-email-liulongfang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614838735-52668-2-git-send-email-liulongfang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Mar 04, 2021 at 02:18:54PM +0800, Longfang Liu wrote: > > @@ -727,7 +725,7 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, struct sec_req *req, > struct aead_request *aead_req = req->aead_req.aead_req; > struct sec_cipher_req *c_req = &req->c_req; > struct sec_qp_ctx *qp_ctx = req->qp_ctx; > - struct device *dev = SEC_CTX_DEV(ctx); > + struct device *dev = ctx->dev; > int copy_size, pbuf_length; > int req_id = req->req_id; > > @@ -737,11 +735,9 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, struct sec_req *req, > copy_size = c_req->c_len; > > pbuf_length = sg_copy_from_buffer(dst, sg_nents(dst), > - qp_ctx->res[req_id].pbuf, > - copy_size); > - > + qp_ctx->res[req_id].pbuf, copy_size); > if (unlikely(pbuf_length != copy_size)) > - dev_err(dev, "copy pbuf data to dst error!\n"); > + dev_err(ctx->dev, "copy pbuf data to dst error!\n"); > } This triggers an unused warning on dev. Please fix. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt