From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17DDC433E0 for ; Fri, 12 Mar 2021 13:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA36B64F53 for ; Fri, 12 Mar 2021 13:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbhCLNNs (ORCPT ); Fri, 12 Mar 2021 08:13:48 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:54522 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbhCLNNc (ORCPT ); Fri, 12 Mar 2021 08:13:32 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lKhbG-0006H4-E2; Sat, 13 Mar 2021 00:13:07 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 13 Mar 2021 00:13:06 +1100 Date: Sat, 13 Mar 2021 00:13:06 +1100 From: Herbert Xu To: Meng Yu Cc: davem@davemloft.net, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, tudor.ambarus@microchip.com, linux-crypto@vger.kernel.org, xuzaibo@huawei.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 0/7] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Message-ID: <20210312131306.GH31502@gondor.apana.org.au> References: <1614839750-29670-1-git-send-email-yumeng18@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614839750-29670-1-git-send-email-yumeng18@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Mar 04, 2021 at 02:35:43PM +0800, Meng Yu wrote: > 1. Move curve ID from the key into the algorithm name (like 'ecdh-nist-pxxx' > so we get its tfm like 'crypto_alloc_kpp("ecdh-nist-p256", 0, 0)'), > in 'crypto/ecc.c' (has been verified by testmgr) and 'crypto/atmel-ecc.c' > (only compiled, not do test), and modify 'testmgr.c' and 'net/bluetooth/smp.c' > (only compiled, not do test) to adapt the modification; > > 2. Add new file 'include/crypto/ecc_curve.h', and move 'struct ecc_point' and > 'struct ecc_curve' definitions to it, also add new APIs 'ecc_get_curveXXX' > into it, with these APIs, users in kernel tree can get ECDH and > curve25519 parameters; > > 3. Add ECDH and CURVE25519 algorithms support for Kunpeng 930. > > v9->v10: > - patch #3: delete 'atmel_ecdh_supported_curve' and 'n_sz' in atmel-ecc.c > > v8->v9: > - patch #3: squash patches 3-5 in v8 into one in v9 > - patch #4: delete ECDH curve parameters: P224, P384 and P521 > - patch #5: delete ecdh-nist-p224, ecdh-nist-p384 and ecdh-nist-p521 support in HPRE > > v7->v8: > - patch #3 and #5: move the curve ID from the key into the algorithm name instead > > v6->v7: > - patch #4: add function interface to expose elliptic curve parameters > - patch #4: eliminate warning by 'kernel test robot' > - patch #5: add function interface to expose curve25519 parameters > > v5->v6: > - patch #1: add a new patch (the first patch), which is the "depend on" patch before > > v4->v5: > - patch #4: delete P-128 and P-320 curve, as the few using case in the kernel > > v3 -> v4: > - patch #3: add new, and move ecc_curve params to "include/crypto" > > v2 -> v3: > - patch #5: fix sparse warnings > - patch #5: add 'CRYPTO_LIB_CURVE25519_GENERIC' in 'Kconfig' > > v1 -> v2: > - patch #5: delete `curve25519_null_point' > > > Meng Yu (7): > crypto: hisilicon/hpre - add version adapt to new algorithms > crypto: hisilicon/hpre - add algorithm type > crypto: move curve_id of ECDH from the key to algorithm name > crypto: and expose ecc curves > crypto: hisilicon/hpre - add 'ECDH' algorithm > crypto: add curve25519 params and expose them > crypto: hisilicon/hpre - add 'CURVE25519' algorithm > > crypto/ecc.c | 11 +- > crypto/ecc.h | 37 +- > crypto/ecc_curve_defs.h | 17 + > crypto/ecdh.c | 72 ++- > crypto/ecdh_helper.c | 4 +- > crypto/testmgr.c | 13 +- > crypto/testmgr.h | 34 +- > drivers/crypto/atmel-ecc.c | 28 +- > drivers/crypto/hisilicon/Kconfig | 1 + > drivers/crypto/hisilicon/hpre/hpre.h | 17 +- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 881 +++++++++++++++++++++++++++- > drivers/crypto/hisilicon/hpre/hpre_main.c | 12 +- > drivers/crypto/hisilicon/qm.c | 4 +- > drivers/crypto/hisilicon/qm.h | 4 +- > drivers/crypto/hisilicon/sec2/sec.h | 4 +- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 4 +- > drivers/crypto/hisilicon/sec2/sec_crypto.h | 4 +- > drivers/crypto/hisilicon/zip/zip.h | 4 +- > drivers/crypto/hisilicon/zip/zip_crypto.c | 4 +- > include/crypto/ecc_curve.h | 60 ++ > include/crypto/ecdh.h | 2 - > net/bluetooth/ecdh_helper.c | 2 - > net/bluetooth/selftest.c | 2 +- > net/bluetooth/smp.c | 6 +- > 24 files changed, 1086 insertions(+), 141 deletions(-) > create mode 100644 include/crypto/ecc_curve.h All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt