From: Rob Herring <robh@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Thara Gopinath <thara.gopinath@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bhupesh.linux@gmail.com
Subject: Re: [PATCH 2/8] dt-bindings: crypto : Add new compatible strings for qcom-qce
Date: Tue, 16 Mar 2021 16:28:25 -0600 [thread overview]
Message-ID: <20210316222825.GA3792517@robh.at.kernel.org> (raw)
In-Reply-To: <20210310052503.3618486-3-bhupesh.sharma@linaro.org>
On Wed, Mar 10, 2021 at 10:54:57AM +0530, Bhupesh Sharma wrote:
> Newer qcom chips support newer versions of the qce IP, so add
> new compatible strings for qcom-qce (in addition to the existing
> "qcom,crypto-v5.1").
>
> With [1], Thara tried to add the support for new compatible strings,
> but we couldn't conclude on the approach to be used. Since we have
> a number of new qcom arm64 SoCs available now, several of which
> support the same crypto IP version, so it makes more sense to use
> the IP version for the compatible string, rather than using the soc
> name as the compatible string.
>
> [1]. https://lore.kernel.org/linux-arm-msm/20201119155233.3974286-7-thara.gopinath@linaro.org/
>
> Cc: Thara Gopinath <thara.gopinath@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Gross <agross@kernel.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: bhupesh.linux@gmail.com
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> index 07ee1b12000b..217b37dbd58a 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> @@ -2,7 +2,11 @@ Qualcomm crypto engine driver
>
> Required properties:
>
> -- compatible : should be "qcom,crypto-v5.1"
> +- compatible : Supported versions are:
> + - "qcom,crypto-v5.1", for ipq6018
> + - "qcom,crypto-v5.4", for sdm845, sm8150
2 SoCs sharing 1 version doesn't convince me on using version numbers.
Having 4 versions for 5 SoCs further convinces me you should stick with
SoC specific compatibles as *everyone* else does (including most QCom
bindings).
> + - "qcom,crypto-v5.5", for sm8250
> + - "qcom,crypto-v5.6", for sm8350
> - reg : specifies base physical address and size of the registers map
> - clocks : phandle to clock-controller plus clock-specifier pair
> - clock-names : "iface" clocks register interface
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-03-16 22:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 5:24 [PATCH 0/8] Enable Qualcomm Crypto Engine on sm8250 Bhupesh Sharma
2021-03-10 5:24 ` [PATCH 1/8] dt-bindings: qcom-qce: Add 'iommus' to required properties Bhupesh Sharma
2021-03-10 5:24 ` [PATCH 2/8] dt-bindings: crypto : Add new compatible strings for qcom-qce Bhupesh Sharma
2021-03-16 22:28 ` Rob Herring [this message]
2021-03-17 13:20 ` Bhupesh Sharma
2021-03-17 14:25 ` Thara Gopinath
2021-03-10 5:24 ` [PATCH 3/8] arm64/dts: qcom: sdm845: Use RPMH_CE_CLK macro directly Bhupesh Sharma
2021-03-10 5:24 ` [PATCH 4/8] dt-bindings/clock: qcom: sm8250: Add gcc clocks for sm8250 crypto block Bhupesh Sharma
[not found] ` <161567012068.1478170.1203237376997442299@swboyd.mtv.corp.google.com>
2021-03-15 7:01 ` Bhupesh Sharma
2021-03-10 5:25 ` [PATCH 5/8] clk: qcom: clk-rpmh: Add CE clock on sm8250 Bhupesh Sharma
2021-03-10 5:25 ` [PATCH 6/8] clk: qcom: Add gcc clocks for crypto block " Bhupesh Sharma
2021-03-10 5:25 ` [PATCH 7/8] drivers: crypto: qce: Enable support for crypto engine " Bhupesh Sharma
2021-03-10 5:25 ` [PATCH 8/8] arm64/dts: qcom: sm8250: Add dt entries to support crypto engine Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316222825.GA3792517@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).