From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C91CC4320E for ; Fri, 30 Jul 2021 00:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA3046101C for ; Fri, 30 Jul 2021 00:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229565AbhG3Ab0 (ORCPT ); Thu, 29 Jul 2021 20:31:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:57966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhG3AbZ (ORCPT ); Thu, 29 Jul 2021 20:31:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 89A5F60F21; Fri, 30 Jul 2021 00:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627605081; bh=tLa7ubS7DmnPV6jzyo5485j3Db4T2l9MF1KXEfHI+rs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qacHkv84pqSlRrdx8XK1m8p5gU2or65oviojOphjbshITub8rsRgZqR8HXt9hUe4R f1DaAoTQohTwGNwlq2ulcT7omqrE+U//1Cw4MT59FUFms5LD/C6suVTbQiSBWeD/Sl CzxLMalubLfcWU+LQb3Q685wJj+sjJ+7P6JBvrpMMJmK2lrTEIFuDZcTXjYdSadKpo DTJDroAcl6BIC25Ia/VHLwXJ/LpiRLlyAl0qB1dfciwpVinO054xFqIShds1ebePKw P/o0haka1iX7z+dCNgn078EzBuXC6SIQcGgnip9s+BP4EAE8DbaxBBEVdRc+JOhMaw SVoL395bhG1HQ== Date: Fri, 30 Jul 2021 03:31:17 +0300 From: Jarkko Sakkinen To: Ahmad Fatoum Cc: James Morris , "Serge E. Hallyn" , James Bottomley , Mimi Zohar , Sumit Garg , David Howells , Herbert Xu , "David S. Miller" , kernel@pengutronix.de, Andreas Rammhold , David Gstir , Richard Weinberger , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v2] KEYS: trusted: fix use as module when CONFIG_TCG_TPM=m Message-ID: <20210730002101.2tcb3bs2lxdvmuqk@kernel.org> References: <20210721160258.7024-1-a.fatoum@pengutronix.de> <20210727030433.3dwod2elwtdkhwsc@kernel.org> <20210728215200.nfvnm5s2b27ang7i@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jul 29, 2021 at 12:29:38AM +0200, Ahmad Fatoum wrote: > On 28.07.21 23:52, Jarkko Sakkinen wrote: > > On Tue, Jul 27, 2021 at 06:24:49AM +0200, Ahmad Fatoum wrote: > >> On 27.07.21 05:04, Jarkko Sakkinen wrote: > >>>> Reported-by: Andreas Rammhold > >>>> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") > >>>> Signed-off-by: Ahmad Fatoum > >>> > >>> Is it absolutely need to do all this *just* to fix the bug? > >>> > >>> For a pure bug fix the most essential thing is to be able the backport > >>> it to stable kernels. > >> > >> Not much happened in-between, so a backport should be trivial. > >> I can provide these if needed. > > > > "not much" is not good enough. It should be "not anything". > > "Not much" [code that could conflict was added in-between]. > > I just checked and it applies cleanly on v5.13. On the off chance > that this patch conflicts with another stable backport by the time > it's backported, I'll get a friendly automated email and send out > a rebased patch. What you should do is to split this into patch that exactly fixes the issue, and to one that adds the "niceties". /Jarkko