From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: [PATCH] crypto: api - Export crypto_boot_test_finished
Date: Mon, 27 Sep 2021 19:23:42 +0800 [thread overview]
Message-ID: <20210927112341.GA22483@gondor.apana.org.au> (raw)
In-Reply-To: <20210927143229.543749f4@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> [-- text/plain, encoding quoted-printable, charset: US-ASCII, 18 lines --]
>
> Hi all,
>
> After merging the crypto tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!
>
> Caused by commit
>
> adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
>
> I have reverted that commit for today.
Oops, does this patch fix the problem?
---8<---
We need to export crypto_boot_test_finished in case api.c is
built-in while algapi.c is built as a module.
Fixes: adad556efcdd ("crypto: api - Fix built-in testing dependency failures")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/crypto/api.c b/crypto/api.c
index 1cf1f03347cc..ee5991fe11f8 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -32,6 +32,7 @@ BLOCKING_NOTIFIER_HEAD(crypto_chain);
EXPORT_SYMBOL_GPL(crypto_chain);
DEFINE_STATIC_KEY_FALSE(crypto_boot_test_finished);
+EXPORT_SYMBOL_GPL(crypto_boot_test_finished);
static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg);
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-09-27 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 4:32 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2021-09-27 11:23 ` Herbert Xu [this message]
2021-09-28 5:16 ` [PATCH] crypto: api - Export crypto_boot_test_finished Stephen Rothwell
2021-10-25 6:28 ` Michael Ellerman
2021-10-26 4:38 ` Herbert Xu
2021-10-29 6:09 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927112341.GA22483@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).