From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B5DC43331 for ; Wed, 13 Nov 2019 00:27:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D87B2084E for ; Wed, 13 Nov 2019 00:27:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="X1rU415t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726978AbfKMA12 (ORCPT ); Tue, 12 Nov 2019 19:27:28 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.82]:15239 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfKMA12 (ORCPT ); Tue, 12 Nov 2019 19:27:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573604845; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=5xqNjpajXQkP+Y+TYhP+1nqtNztIwRwTN9C3b1nVHUY=; b=X1rU415tdviRpjQceWkcfn6amuVywC2wrmvGHD0vX+/0Q/ojhpbCiZztJnGQMktyJ3 hRE9q/jF88Qlhxljf8cNaJ7sO9SCTe7PHADU3v1ymkqdntKRom8yJBJdfCmvKnFDYZl1 uLUeGzk0N13gtd+N/C6lgCYiAmDNzaEtmul1Ln2DwBxTz/DFtzPsBohx/EREqFGaQj98 TD4EErzSjxIVoyvmMlEZcFH0X6L/BYc7OibBIXSjmNsRDtACdpxezHW76QFGVO2AG8pW R5lLdXExZWR2BK0PD0DhpeGjbYwDhzKASno/NLzhEPOYHf+QwA79wKiw2PUmqWaXpZQg 3TqQ== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9zmwdNLqV/Nz7PsNPEA==" X-RZG-CLASS-ID: mo00 Received: from positron.chronox.de by smtp.strato.de (RZmta 44.29.0 SBL|AUTH) with ESMTPSA id N09a57vAD0Q1ABR (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 13 Nov 2019 01:26:01 +0100 (CET) From: Stephan =?ISO-8859-1?Q?M=FCller?= To: kbuild test robot Cc: kbuild-all@lists.01.org, Arnd Bergmann , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman Subject: Re: [PATCH v24 01/12] Linux Random Number Generator Date: Wed, 13 Nov 2019 01:25:58 +0100 Message-ID: <2264655.zbyk6f8WaQ@positron.chronox.de> In-Reply-To: <201911130807.RnsJ5SVf%lkp@intel.com> References: <2369119.jSEA3qhmGI@positron.chronox.de> <201911130807.RnsJ5SVf%lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Mittwoch, 13. November 2019, 01:14:05 CET schrieb kbuild test robot: Hi kbuild, > Hi "Stephan, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on char-misc/char-misc-testing] > [also build test ERROR on v5.4-rc7 next-20191112] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system. BTW, we also suggest to use '--base' option to > specify the base tree in git format-patch, please see > https://stackoverflow.com/a/37406982] > > url: > https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-ap > proach-with-full-SP800-90B-compliance/20191113-040847 base: > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > 01b59c763fe2de845b65900485b141fdd7bbf93e config: mips-allmodconfig > (attached as .config) > compiler: mips-linux-gcc (GCC) 7.4.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.4.0 make.cross ARCH=mips > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > drivers/char/lrng/lrng_sw_noise.c: In function 'add_interrupt_randomness': > >> drivers/char/lrng/lrng_sw_noise.c:145:23: error: invalid application of > >> 'sizeof' to incomplete type 'struct pt_regs' > size_t n = (sizeof(struct pt_regs) / sizeof(u32)); > ^~~~~~ > > >> drivers/char/lrng/lrng_sw_noise.c:147:9: error: implicit declaration of > >> function 'instruction_pointer'; did you mean 'instruction_hazard'? > >> [-Werror=implicit-function-declaration] > ip = instruction_pointer(regs); > ^~~~~~~~~~~~~~~~~~~ > instruction_hazard > cc1: some warnings being treated as errors > > vim +145 drivers/char/lrng/lrng_sw_noise.c Thank you for the report. Both issues are fixed by including . This will be fixed with the next installment of the patch. > > 125 > 126 /** > 127 * Hot code path - Callback for interrupt handler > 128 */ > 129 void add_interrupt_randomness(int irq, int irq_flags) > 130 { > 131 lrng_time_process(); > 132 > 133 if (!lrng_pool_highres_timer()) { > 134 struct pt_regs *regs = get_irq_regs(); > 135 static atomic_t reg_idx = ATOMIC_INIT(0); > 136 u64 ip; > 137 > 138 lrng_pool_lfsr_u32(jiffies); > 139 lrng_pool_lfsr_u32(irq); > 140 lrng_pool_lfsr_u32(irq_flags); > 141 > 142 if (regs) { > 143 u32 *ptr = (u32 *)regs; > 144 int reg_ptr = atomic_add_return_relaxed(1, ®_idx); > > > 145 size_t n = (sizeof(struct pt_regs) / sizeof(u32)); > > 146 > > > 147 ip = instruction_pointer(regs); > > --- > 0-DAY kernel test infrastructure Open Source Technology > Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel > Corporation Ciao Stephan