From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
dhowells@redhat.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, jmorris@namei.org, serge@hallyn.com,
nramas@linux.microsoft.com, tusharsu@linux.microsoft.com,
zohar@linux.ibm.com, gilad@benyossef.com, pvanleeuwen@rambus.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-security-module@vger.kernel.org,
zhang.jia@linux.alibaba.com
Subject: Re: [PATCH v3 0/8] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm
Date: Tue, 16 Jun 2020 17:35:58 +0800 [thread overview]
Message-ID: <254bf52e-eeb8-b615-be2a-d5cba976b63a@linux.alibaba.com> (raw)
In-Reply-To: <20200609205837.osganry2tyzwvanz@altlinux.org>
On 2020/6/10 4:58, Vitaly Chikunov wrote:
> Tianjia,
>
> On Tue, Jun 09, 2020 at 09:48:47PM +0800, Tianjia Zhang wrote:
>> Hello all,
>>
>> This new module implement the OSCCA certificate and SM2 public key
>> algorithm. It was published by State Encryption Management Bureau, China.
>> List of specifications for OSCCA certificate and SM2 elliptic curve
>> public key cryptography:
>>
>> * GM/T 0003.1-2012
>> * GM/T 0003.2-2012
>> * GM/T 0003.3-2012
>> * GM/T 0003.4-2012
>> * GM/T 0003.5-2012
>> * GM/T 0015-2012
>> * GM/T 0009-2012
>>
>> IETF: https://tools.ietf.org/html/draft-shen-sm2-ecdsa-02
>> oscca: http://www.oscca.gov.cn/sca/xxgk/2010-12/17/content_1002386.shtml
>> scctc: http://www.gmbz.org.cn/main/bzlb.html
>>
>> These patchs add the OID object identifier defined by OSCCA. The
>> x509 certificate supports sm2-with-sm3 type certificate parsing
>> and verification.
>>
>> The sm2 algorithm is based on libgcrypt's mpi implementation, and has
>> made some additions to the kernel's original mpi library, and added the
>> implementation of ec to better support elliptic curve-like algorithms.
>>
>> sm2 has good support in both openssl and gnupg projects, and sm3 and sm4
>> of the OSCCA algorithm family have also been implemented in the kernel.
>>
>> Among them, sm3 and sm4 have been well implemented in the kernel.
>> This group of patches has newly introduced sm2. In order to implement
>> sm2 more perfectly, I expanded the mpi library and introduced the
>> ec implementation of the mpi library as the basic algorithm. Compared
>> to the kernel's crypto/ecc.c, the implementation of mpi/ec.c is more
>> complete and elegant, sm2 is implemented based on these algorithms.
>
> Does it use constant-time algorithms?
>
> Thanks,
>
Sorry for not responding in time.
This algorithm is constant-time algorithms, and this logic is
implemented in ec_mul_point().
Will you consider implementing ecrdsa based on the mpi ec algorithm in
the future?
Thanks and best,
Tianjia
prev parent reply other threads:[~2020-06-16 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 13:48 [PATCH v3 0/8] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 1/8] crypto: sm3 - export crypto_sm3_final function Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 2/8] lib/mpi: Extend the MPI library Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 3/8] lib/mpi: Introduce ec implementation to " Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 4/8] crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 5/8] crypto: testmgr - support test with different ciphertext per encryption Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 6/8] X.509: support OSCCA certificate parse Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 7/8] X.509: support OSCCA sm2-with-sm3 certificate verification Tianjia Zhang
2020-06-09 13:48 ` [PATCH v3 8/8] integrity: Asymmetric digsig supports SM2-with-SM3 algorithm Tianjia Zhang
2020-06-09 20:58 ` [PATCH v3 0/8] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm Vitaly Chikunov
2020-06-16 9:35 ` Tianjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254bf52e-eeb8-b615-be2a-d5cba976b63a@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nramas@linux.microsoft.com \
--cc=pvanleeuwen@rambus.com \
--cc=serge@hallyn.com \
--cc=tusharsu@linux.microsoft.com \
--cc=zhang.jia@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).