linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	davem@davemloft.net, dhowells@redhat.com, zohar@linux.ibm.com,
	linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
	linux-integrity@vger.kernel.org,
	Saulo Alessandre <saulo.alessandre@tse.jus.br>
Subject: Re: [PATCH v9 6/9] crypto: Add NIST P384 curve parameters
Date: Thu, 4 Mar 2021 08:59:36 -0500	[thread overview]
Message-ID: <37e5c232-11e8-0533-ab3e-676829091d19@linux.ibm.com> (raw)
In-Reply-To: <20210304052809.GB25972@gondor.apana.org.au>

On 3/4/21 12:28 AM, Herbert Xu wrote:
> On Thu, Feb 25, 2021 at 11:07:59AM -0500, Stefan Berger wrote:
>> From: Saulo Alessandre <saulo.alessandre@tse.jus.br>
>>
>> * crypto/ecc_curve_defs.h
>>    - add nist_p384 params
>>
>> * include/crypto/ecdh.h
>>    - add ECC_CURVE_NIST_P384
>>
>> Signed-off-by: Saulo Alessandre <saulo.alessandre@tse.jus.br>
>> Tested-by: Stefan Berger <stefanb@linux.ibm.com>
>> ---
>>   crypto/ecc_curve_defs.h | 32 ++++++++++++++++++++++++++++++++
>>   include/crypto/ecdh.h   |  1 +
>>   2 files changed, 33 insertions(+)
> Can you reorder the patches so that the crypto patches come first
> and then I can apply them?

Yes, sounds good.

Are you going to take the other patches as well, except for maybe 9/9, 
which depends on Nayan's patch series. Mimi suggested to me to ask you 
whether you could create a topic branch where we can apply other patches 
to, such as Nayna's?

The NIST P384 patch temporarily introduces this warning, which goes away 
when the immediately following patch (current 7/9) is applied. Is this 
an issue or should I squash Saulo's patches or put the top hunk from 7/9 
into 6/9?


In file included from crypto/ecc.c:38:
crypto/ecc_curve_defs.h:76:25: warning: ?nist_p384? defined but not used 
[-Wunused-variable]
    76 | static struct ecc_curve nist_p384 = {
       |                         ^~~~~~~~~

    Stefan


>
> Thanks,



  reply	other threads:[~2021-03-04 14:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 16:07 [PATCH v9 0/9] Add support for x509 certs with NIST P384/256/192 keys Stefan Berger
2021-02-25 16:07 ` [PATCH v9 1/9] crypto: Add support for ECDSA signature verification Stefan Berger
2021-02-25 16:07 ` [PATCH v9 2/9] x509: Detect sm2 keys by their parameters OID Stefan Berger
2021-03-03 23:46   ` Stefan Berger
2021-03-05  7:37     ` Tianjia Zhang
2021-03-05 15:04       ` Stefan Berger
2021-03-08  6:58         ` Tianjia Zhang
2021-02-25 16:07 ` [PATCH v9 3/9] x509: Add support for parsing x509 certs with ECDSA keys Stefan Berger
2021-02-25 16:07 ` [PATCH v9 4/9] ima: Support EC keys for signature verification Stefan Berger
2021-02-25 16:07 ` [PATCH v9 5/9] x509: Add OID for NIST P384 and extend parser for it Stefan Berger
2021-02-25 16:07 ` [PATCH v9 6/9] crypto: Add NIST P384 curve parameters Stefan Berger
2021-03-04  5:28   ` Herbert Xu
2021-03-04 13:59     ` Stefan Berger [this message]
2021-03-04 22:31       ` Herbert Xu
2021-02-25 16:08 ` [PATCH v9 7/9] crypto: Add math to support fast NIST P384 Stefan Berger
2021-02-25 16:08 ` [PATCH v9 8/9] ecdsa: Register NIST P384 and extend test suite Stefan Berger
2021-02-25 16:08 ` [PATCH v9 9/9] certs: Add support for using elliptic curve keys for signing modules Stefan Berger
2021-02-27  3:35   ` yumeng
2021-03-01 13:11     ` Mimi Zohar
2021-03-02  1:04       ` yumeng
2021-03-01 21:19     ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37e5c232-11e8-0533-ab3e-676829091d19@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@puiterwijk.org \
    --cc=saulo.alessandre@tse.jus.br \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).