linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
	Andy Whitcroft <apw@canonical.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.
Date: Tue, 21 May 2019 11:10:54 -0700	[thread overview]
Message-ID: <3bd9fef9b11ccf49171227e9507cda0a899f8f9d.camel@perches.com> (raw)
In-Reply-To: <3ac55e59-a75c-0b9a-be24-148007bb522e@c-s.fr>

On Tue, 2019-05-21 at 17:54 +0000, Christophe Leroy wrote:
> Hi Joe & Andy
[]
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
[]
> > @@ -2356,7 +2356,7 @@ static struct talitos_alg_template driver_algs[] = {
> >   			.base = {
> >   				.cra_name = "authenc(hmac(sha1),cbc(aes))",
> >   				.cra_driver_name = "authenc-hmac-sha1-"
> > -						   "cbc-aes-talitos",
> > +						   "cbc-aes-talitos-hsna",
> 
> checkpatch reports the following warning on the above:
> 
> WARNING: quoted string split across lines
> #27: FILE: drivers/crypto/talitos.c:2359:
>   				.cra_driver_name = "authenc-hmac-sha1-"
> +						   "cbc-aes-talitos-hsna",
> 
> 
> But when I fixes the patch as follows, I get another warning:
> 
> @@ -2355,8 +2355,7 @@ static struct talitos_alg_template driver_algs[] = {
>   		.alg.aead = {
>   			.base = {
>   				.cra_name = "authenc(hmac(sha1),cbc(aes))",
> -				.cra_driver_name = "authenc-hmac-sha1-"
> -						   "cbc-aes-talitos",
> +				.cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos-hsna",
>   				.cra_blocksize = AES_BLOCK_SIZE,
>   				.cra_flags = CRYPTO_ALG_ASYNC,
>   			},
> 
> 
> 
> WARNING: line over 80 characters
> #28: FILE: drivers/crypto/talitos.c:2358:
> +				.cra_driver_name = "authenc-hmac-sha1-cbc-aes-talitos-hsna",
> 
> 
> So, how should this be fixed ?

For at least now, by ignoring this checkpatch message.

It's a brainless script.  You are not brainless.


  reply	other threads:[~2019-05-21 18:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 13:34 [PATCH v1 00/15] Fixing selftests failure on Talitos driver Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 01/15] crypto: talitos - fix skcipher failure due to wrong output IV Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos Christophe Leroy
2019-05-21 17:54   ` Christophe Leroy
2019-05-21 18:10     ` Joe Perches [this message]
2019-05-21 13:34 ` [PATCH v1 03/15] crypto: talitos - reduce max key size for SEC1 Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 04/15] crypto: talitos - check AES key size Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 05/15] crypto: talitos - fix CTR alg blocksize Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 06/15] crypto: talitos - check data blocksize in ablkcipher Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 07/15] crypto: talitos - fix ECB algs ivsize Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 08/15] crypto: talitos - Do not modify req->cryptlen on decryption Christophe Leroy
2019-05-28  8:20   ` Horia Geanta
2019-05-21 13:34 ` [PATCH v1 09/15] crypto: talitos - HMAC SNOOP NO AFEU mode requires SW icv checking Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 10/15] crypto: talitos - properly handle split ICV Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 11/15] crypto: talitos - Align SEC1 accesses to 32 bits boundaries Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 12/15] crypto: talitos - fix AEAD processing Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 13/15] Revert "crypto: talitos - export the talitos_submit function" Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 14/15] crypto: talitos - use IS_ENABLED() in has_ftr_sec1() Christophe Leroy
2019-05-21 13:34 ` [PATCH v1 15/15] crypto: talitos - use SPDX-License-Identifier Christophe Leroy
2019-05-28  9:17 ` [PATCH v1 00/15] Fixing selftests failure on Talitos driver Horia Geanta
2019-05-28 16:48   ` Christophe Leroy
2019-05-30 13:42 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bd9fef9b11ccf49171227e9507cda0a899f8f9d.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).