From: Markus Elfring <Markus.Elfring@web.de>
To: linux-crypto@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Chuhong Yuan" <hslester96@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Łukasz Stelmach" <l.stelmach@samsung.com>,
"Matt Mackall" <mpm@selenic.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
YueHaibing <yuehaibing@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH] hwrng: xgene - Delete an error message in xgene_rng_probe()
Date: Sat, 4 Apr 2020 17:17:19 +0200 [thread overview]
Message-ID: <45447185-d64f-027c-7bca-c59ea21e6021@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Apr 2020 17:07:34 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/char/hw_random/xgene-rng.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c
index d7516a446987..008e6db9ce01 100644
--- a/drivers/char/hw_random/xgene-rng.c
+++ b/drivers/char/hw_random/xgene-rng.c
@@ -328,10 +328,8 @@ static int xgene_rng_probe(struct platform_device *pdev)
return PTR_ERR(ctx->csr_base);
rc = platform_get_irq(pdev, 0);
- if (rc < 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
+ if (rc < 0)
return rc;
- }
ctx->irq = rc;
dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
--
2.26.0
next reply other threads:[~2020-04-04 15:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 15:17 Markus Elfring [this message]
2020-04-16 6:51 ` [PATCH] hwrng: xgene - Delete an error message in xgene_rng_probe() Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45447185-d64f-027c-7bca-c59ea21e6021@web.de \
--to=markus.elfring@web.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=hslester96@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mpm@selenic.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=tglx@linutronix.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).