From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Mueller Subject: Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Date: Mon, 17 Oct 2016 23:14:42 +0200 Message-ID: <4884703.jrSbDN45dS@tauon.atsec.com> References: <4169224b6858d1cf149f1a73f8a03603fa19076d.1476638125.git.luto@kernel.org> <1709183.xhj4cRUFK9@tauon.atsec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Andy Lutomirski , linux-crypto@vger.kernel.org, "linux-kernel@vger.kernel.org" , Matt Mackall , Herbert Xu , Rusty Russell , Jens Axboe , Matt Mullins To: Andy Lutomirski Return-path: Received: from mail.eperm.de ([89.247.134.16]:53636 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964894AbcJQVOs (ORCPT ); Mon, 17 Oct 2016 17:14:48 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: Am Montag, 17. Oktober 2016, 14:03:17 CEST schrieb Andy Lutomirski: Hi Andy, > On Mon, Oct 17, 2016 at 11:36 AM, Stephan Mueller wrote: > > Am Montag, 17. Oktober 2016, 10:30:13 CEST schrieb Andy Lutomirski: > > > > Hi Andy, > > > >> Sure, but shouldn't that be a separate patch covering the whole hw_crypto > >> core? > > > > I think that you are right -- there are many more cases where a memset(0) > > is warranted. > > > > Do you want to make this change or should I send a patch? > > Can you do it? I have my work cut out for me making sure that all the > known regressions get stomped quickly... Sure, will do. Thanks. Ciao Stephan