From: "Stephan Müller" <smueller@chronox.de>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org
Subject: [PATCH 02/13] crypto: gcm_generic - copy AAD during encryption
Date: Tue, 10 Jan 2017 02:37:06 +0100 [thread overview]
Message-ID: <5602132.eBAxP8yXb3@positron.chronox.de> (raw)
In-Reply-To: <10526995.lyZ7Je1KMx@positron.chronox.de>
>From 8690e52f7e90663b14b2490d37a3b5b1c5a53bfe Mon Sep 17 00:00:00 2001
From: Stephan Mueller <smueller@chronox.de>
Date: Mon, 9 Jan 2017 12:35:35 +0100
Subject:
Invoke the crypto_aead_copy_ad function during the encryption code path
to copy the AAD from the source to the destination buffer.
Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
crypto/gcm.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/crypto/gcm.c b/crypto/gcm.c
index b7ad808..1ca0b05c 100644
--- a/crypto/gcm.c
+++ b/crypto/gcm.c
@@ -496,11 +496,16 @@ static int crypto_gcm_encrypt(struct aead_request *req)
struct crypto_gcm_req_priv_ctx *pctx = crypto_gcm_reqctx(req);
struct skcipher_request *skreq = &pctx->u.skreq;
u32 flags = aead_request_flags(req);
+ int err;
crypto_gcm_init_common(req);
crypto_gcm_init_crypt(req, req->cryptlen);
skcipher_request_set_callback(skreq, flags, gcm_encrypt_done, req);
+ err = crypto_aead_copy_ad(req);
+ if (err)
+ return err;
+
return crypto_skcipher_encrypt(skreq) ?:
gcm_encrypt_continue(req, flags);
}
@@ -866,9 +871,15 @@ static struct aead_request *crypto_rfc4106_crypt(struct aead_request *req)
static int crypto_rfc4106_encrypt(struct aead_request *req)
{
+ int err;
+
if (req->assoclen != 16 && req->assoclen != 20)
return -EINVAL;
+ err = crypto_aead_copy_ad(req);
+ if (err)
+ return err;
+
req = crypto_rfc4106_crypt(req);
return crypto_aead_encrypt(req);
@@ -1099,6 +1110,12 @@ static int crypto_rfc4543_copy_src_to_dst(struct aead_request *req, bool enc)
static int crypto_rfc4543_encrypt(struct aead_request *req)
{
+ int err;
+
+ err = crypto_aead_copy_ad(req);
+ if (err)
+ return err;
+
return crypto_rfc4543_crypt(req, true);
}
--
2.9.3
next prev parent reply other threads:[~2017-01-10 1:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 1:36 [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers Stephan Müller
2017-01-10 1:36 ` [PATCH 01/13] crypto: service function to copy AAD from src to dst Stephan Müller
2017-01-10 1:37 ` Stephan Müller [this message]
2017-01-10 1:37 ` [PATCH 03/13] crypto: ccm_generic - copy AAD during encryption Stephan Müller
2017-01-10 1:37 ` [PATCH 04/13] crypto: rfc4106-gcm-aesni " Stephan Müller
2017-01-10 1:38 ` [PATCH 05/13] crypto: ccm-aes-ce " Stephan Müller
2017-01-10 1:38 ` [PATCH 06/13] crypto: talitos " Stephan Müller
2017-01-10 1:38 ` [PATCH 07/13] crypto: picoxcell " Stephan Müller
2017-01-10 1:39 ` [PATCH 08/13] crypto: ixp4xx " Stephan Müller
2017-01-10 1:39 ` [PATCH 09/13] crypto: atmel " Stephan Müller
2017-01-10 1:39 ` [PATCH 10/13] crypto: caam " Stephan Müller
2017-01-10 1:40 ` [PATCH 11/13] crypto: chelsio " Stephan Müller
2017-01-10 1:40 ` [PATCH 12/13] crypto: nx " Stephan Müller
2017-01-10 1:41 ` [PATCH 13/13] crypto: qat " Stephan Müller
2017-01-12 6:19 ` [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers Herbert Xu
2017-01-12 11:22 ` Stephan Müller
2017-01-12 14:57 ` Herbert Xu
2017-01-12 15:23 ` Stephan Müller
2017-01-12 15:27 ` Herbert Xu
2017-01-12 15:34 ` Stephan Müller
2017-01-12 15:39 ` Herbert Xu
2017-01-12 15:50 ` Stephan Müller
2017-01-12 15:53 ` Herbert Xu
2017-01-12 16:01 ` Stephan Müller
2017-01-12 16:06 ` Herbert Xu
2017-01-12 16:37 ` Stephan Müller
2017-01-13 10:23 ` Herbert Xu
2017-01-13 10:58 ` Stephan Müller
2017-01-13 11:04 ` Herbert Xu
2017-01-13 11:12 ` Stephan Müller
2017-01-13 11:14 ` Herbert Xu
2017-01-13 11:19 ` Stephan Müller
2017-01-13 11:26 ` Herbert Xu
2017-01-13 11:30 ` Stephan Müller
2017-01-13 11:33 ` Herbert Xu
2017-01-13 11:36 ` Stephan Müller
2017-01-13 11:39 ` Herbert Xu
2017-01-20 17:07 ` Cyrille Pitchen
2017-01-20 20:28 ` Stephan Müller
2017-01-23 13:10 ` Herbert Xu
2017-01-12 12:43 ` Stephan Müller
2017-01-18 14:57 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5602132.eBAxP8yXb3@positron.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).