From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE36C433DF for ; Thu, 16 Jul 2020 14:50:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 404AF207E8 for ; Thu, 16 Jul 2020 14:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="mWlX4qGl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728541AbgGPOuD (ORCPT ); Thu, 16 Jul 2020 10:50:03 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.24]:22132 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgGPOuD (ORCPT ); Thu, 16 Jul 2020 10:50:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1594910998; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=OKPFCq7c4Tj37kL5lQQGIMWjl9wVJhrpQCoElsGxEbQ=; b=mWlX4qGlu8/qvtYxjJqSEVgFewp+xT1V2pNBCBozmoc/dGA0O0Oxuhv15w2n4qcfTz W/dUK5fM0iJcj5yTKDzvjwcaJk/00QBeg9UNz06mKAYmKtTMj8+JTbPsxD4wE6Mm/1tl GW9FZaz8fJ84Z6odERjUG0oX0gWEuyjJp/W0MRS2UllqvsHKAIUIATnNEot8e1UR0Idw u2HV+DWPx5N4HWVrplnQdLdv2fdfZ9RRH6dLZvloMu443w0DLQuKaYQ8FyQwA7oZLWmF /5B/YDPYLzCgF1o/aJVINpGFOnGP+dnJjF3EG5leceCdsdrAyX6CqsrFxrOQQgvfX9w7 rMgg== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9x2wdNs6neUFoh7cs0E0=" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 46.10.5 AUTH) with ESMTPSA id y0546bw6GEnr95I (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 16 Jul 2020 16:49:53 +0200 (CEST) From: Stephan Mueller To: Elena Petrova Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Eric Biggers , Ard Biesheuvel , keyring@vger.kernel.org Subject: Re: [PATCH 0/1] crypto: af_alg - add extra parameters for DRBG interface Date: Thu, 16 Jul 2020 16:49:52 +0200 Message-ID: <5740551.2l3rmUXbR5@tauon.chronox.de> In-Reply-To: References: <20200713164857.1031117-1-lenaptr@google.com> <3312053.iIbC2pHGDl@tauon.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Donnerstag, 16. Juli 2020, 16:41:26 CEST schrieb Elena Petrova: Hi Herbert, > > > > With these issues, I would assume you are better off creating your own > > > > kernel module just like I did that externalizes the crypto API to user > > > > space but is only available on your test kernel and will not affect > > > > all > > > > other users. > > > > > > I considered publishing my kernel driver on GitHub, but there appears to > > > be > > > a sufficiently large number of users to justify having this > > > functionality > > > upstream. > > > > So, I should then dust off my AF_ALG KPP and AF_ALG akcipher patches then? > > :-D > Sure :) Long time ago when I released the patches now found in [1] and [2] they where rejected as it was said, the official route to access the RSA/ECDSA and the DH/ECDH ciphers is through the keyring. Obviously this interface of the keyring is not suitable for testing these algorithms. Considering the request that the kernel crypto API ciphers should be testable with arbitrary test vectors, would the dusted-off patches for AF_ALG KPP and akcipher be accepted? Ciao Stephan [1] https://github.com/smuellerDD/libkcapi/tree/master/kernel-patches/4.15-rc3/asym [2] https://github.com/smuellerDD/libkcapi/tree/master/kernel-patches/4.15-rc3/kpp