From: Zhou Wang <wangzhou1@hisilicon.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hao Fang <fanghao11@huawei.com>,
Kenneth Lee <liguozhu@hisilicon.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] crypto: hisilicon - avoid unused function warning
Date: Thu, 19 Sep 2019 16:11:13 +0800 [thread overview]
Message-ID: <5D833821.5000504@hisilicon.com> (raw)
In-Reply-To: <20190913091718.GA6382@gondor.apana.org.au>
On 2019/9/13 17:17, Herbert Xu wrote:
> On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote:
>> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef,
>> so the function causes a warning when CONFIG_PCI_IOV is disabled:
>>
>> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function]
>>
>> Move it into the same #ifdef.
>>
>> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/crypto/hisilicon/zip/zip_main.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Please find a way to fix this warning without reducing compiler
> coverage. I prefer to see any compile issues immediately rather
> than through automated build testing.
>
> Thanks,
>
Sorry for missing this patch.
Seems other drivers also do like using #ifdef. Do you mean something like this:
#ifdef CONFIG_PCI_IOV
sriov_enable()
...
#else
/* stub */
sriov_enable()
...
#endif
Best,
Zhou
next prev parent reply other threads:[~2019-09-19 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:22 [PATCH 1/2] crypto: inside-secure - fix uninitialized-variable warning Arnd Bergmann
2019-09-06 15:22 ` [PATCH 2/2] crypto: hisilicon - avoid unused function warning Arnd Bergmann
2019-09-13 9:17 ` Herbert Xu
2019-09-19 8:11 ` Zhou Wang [this message]
2019-09-19 13:48 ` Herbert Xu
2019-09-19 14:07 ` Arnd Bergmann
2019-09-06 16:08 ` [PATCH 1/2] crypto: inside-secure - fix uninitialized-variable warning Pascal Van Leeuwen
2019-09-06 18:39 ` Arnd Bergmann
2019-09-06 20:18 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D833821.5000504@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=liguozhu@hisilicon.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).