linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] crypto: hisilicon - qm depends on UACCE
@ 2020-02-27  7:12 Zhou Wang
  2020-03-06  1:51 ` Herbert Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Zhou Wang @ 2020-02-27  7:12 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller; +Cc: linux-crypto, Hongbo Yao, Zhou Wang

From: Hongbo Yao <yaohongbo@huawei.com>

If UACCE=m and CRYPTO_DEV_HISI_QM=y, the following error
is seen while building qm.o:

drivers/crypto/hisilicon/qm.o: In function `hisi_qm_init':
(.text+0x23c6): undefined reference to `uacce_alloc'
(.text+0x2474): undefined reference to `uacce_remove'
(.text+0x286b): undefined reference to `uacce_remove'
drivers/crypto/hisilicon/qm.o: In function `hisi_qm_uninit':
(.text+0x2918): undefined reference to `uacce_remove'
make[1]: *** [vmlinux] Error 1
make: *** [autoksyms_recursive] Error 2

This patch fixes the config dependency for QM and ZIP.

reported-by: Hulk Robot <hulkci@huawei.com>
Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
---
 drivers/crypto/hisilicon/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index 8851161..095850d 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -40,6 +40,7 @@ config CRYPTO_DEV_HISI_QM
 	tristate
 	depends on ARM64 || COMPILE_TEST
 	depends on PCI && PCI_MSI
+	depends on UACCE || UACCE=n
 	help
 	  HiSilicon accelerator engines use a common queue management
 	  interface. Specific engine driver may use this module.
@@ -49,6 +50,7 @@ config CRYPTO_DEV_HISI_ZIP
 	depends on PCI && PCI_MSI
 	depends on ARM64 || (COMPILE_TEST && 64BIT)
 	depends on !CPU_BIG_ENDIAN || COMPILE_TEST
+	depends on UACCE || UACCE=n
 	select CRYPTO_DEV_HISI_QM
 	help
 	  Support for HiSilicon ZIP Driver
-- 
2.8.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] crypto: hisilicon - qm depends on UACCE
  2020-02-27  7:12 [PATCH v2] crypto: hisilicon - qm depends on UACCE Zhou Wang
@ 2020-03-06  1:51 ` Herbert Xu
  2020-03-06  2:49   ` Zhou Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2020-03-06  1:51 UTC (permalink / raw)
  To: Zhou Wang; +Cc: David S. Miller, linux-crypto, Hongbo Yao

On Thu, Feb 27, 2020 at 03:12:28PM +0800, Zhou Wang wrote:
> From: Hongbo Yao <yaohongbo@huawei.com>
> 
> If UACCE=m and CRYPTO_DEV_HISI_QM=y, the following error
> is seen while building qm.o:
> 
> drivers/crypto/hisilicon/qm.o: In function `hisi_qm_init':
> (.text+0x23c6): undefined reference to `uacce_alloc'
> (.text+0x2474): undefined reference to `uacce_remove'
> (.text+0x286b): undefined reference to `uacce_remove'
> drivers/crypto/hisilicon/qm.o: In function `hisi_qm_uninit':
> (.text+0x2918): undefined reference to `uacce_remove'
> make[1]: *** [vmlinux] Error 1
> make: *** [autoksyms_recursive] Error 2
> 
> This patch fixes the config dependency for QM and ZIP.
> 
> reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> ---
>  drivers/crypto/hisilicon/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] crypto: hisilicon - qm depends on UACCE
  2020-03-06  1:51 ` Herbert Xu
@ 2020-03-06  2:49   ` Zhou Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Zhou Wang @ 2020-03-06  2:49 UTC (permalink / raw)
  To: Herbert Xu; +Cc: David S. Miller, linux-crypto, Hongbo Yao

On 2020/3/6 9:51, Herbert Xu wrote:
> On Thu, Feb 27, 2020 at 03:12:28PM +0800, Zhou Wang wrote:
>> From: Hongbo Yao <yaohongbo@huawei.com>
>>
>> If UACCE=m and CRYPTO_DEV_HISI_QM=y, the following error
>> is seen while building qm.o:
>>
>> drivers/crypto/hisilicon/qm.o: In function `hisi_qm_init':
>> (.text+0x23c6): undefined reference to `uacce_alloc'
>> (.text+0x2474): undefined reference to `uacce_remove'
>> (.text+0x286b): undefined reference to `uacce_remove'
>> drivers/crypto/hisilicon/qm.o: In function `hisi_qm_uninit':
>> (.text+0x2918): undefined reference to `uacce_remove'
>> make[1]: *** [vmlinux] Error 1
>> make: *** [autoksyms_recursive] Error 2
>>
>> This patch fixes the config dependency for QM and ZIP.
>>
>> reported-by: Hulk Robot <hulkci@huawei.com>
>> Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
>> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
>> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
>> ---
>>  drivers/crypto/hisilicon/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Patch applied.  Thanks.

Thanks and Best,

Zhou

> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-06  2:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27  7:12 [PATCH v2] crypto: hisilicon - qm depends on UACCE Zhou Wang
2020-03-06  1:51 ` Herbert Xu
2020-03-06  2:49   ` Zhou Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).