From: Zhou Wang <wangzhou1@hisilicon.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] crypto: hisilicon/zip - constify struct debugfs_reg32
Date: Sat, 9 May 2020 09:49:26 +0800 [thread overview]
Message-ID: <5EB60C26.8050205@hisilicon.com> (raw)
In-Reply-To: <20200508223502.7258-4-rikard.falkeborn@gmail.com>
On 2020/5/9 6:35, Rikard Falkeborn wrote:
> hzip_dfx_regs is never changed and can be made const.
>
> This allows the compiler to put it in the text section instead of the
> data section.
>
> Before:
> text data bss dec hex filename
> 15236 6160 480 21876 5574 drivers/crypto/hisilicon/zip/zip_main.o
>
> After:
> text data bss dec hex filename
> 15620 5776 480 21876 5574 drivers/crypto/hisilicon/zip/zip_main.o
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks for fixing this.
> ---
> drivers/crypto/hisilicon/zip/zip_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
> index 37db11f96fab..6934a03d21e1 100644
> --- a/drivers/crypto/hisilicon/zip/zip_main.c
> +++ b/drivers/crypto/hisilicon/zip/zip_main.c
> @@ -165,7 +165,7 @@ static const u64 core_offsets[] = {
> [HZIP_DECOMP_CORE5] = 0x309000,
> };
>
> -static struct debugfs_reg32 hzip_dfx_regs[] = {
> +static const struct debugfs_reg32 hzip_dfx_regs[] = {
> {"HZIP_GET_BD_NUM ", 0x00ull},
> {"HZIP_GET_RIGHT_BD ", 0x04ull},
> {"HZIP_GET_ERROR_BD ", 0x08ull},
>
next prev parent reply other threads:[~2020-05-09 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 22:34 [PATCH 0/4] crypto: constify struct debugfs_reg32 Rikard Falkeborn
2020-05-08 22:34 ` [PATCH 1/4] crypto: ccree - " Rikard Falkeborn
2020-05-08 22:35 ` [PATCH 2/4] crypto: hisilicon/hpre " Rikard Falkeborn
2020-05-08 22:35 ` [PATCH 3/4] crypto: hisilicon/zip " Rikard Falkeborn
2020-05-09 1:49 ` Zhou Wang [this message]
2020-05-08 22:35 ` [PATCH 4/4] crypto: hisilicon/sec2 - constify sec_dfx_regs Rikard Falkeborn
2020-05-15 6:21 ` [PATCH 0/4] crypto: constify struct debugfs_reg32 Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EB60C26.8050205@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).