From: Javier Martinez Canillas <firstname.lastname@example.org> To: Arnd Bergmann <email@example.com> Cc: firstname.lastname@example.org, Jamie Iles <email@example.com>, "David S. Miller" <firstname.lastname@example.org>, email@example.com, Herbert Xu <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code Date: Mon, 2 Jan 2017 14:49:57 -0300 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <2309314.lMWYhcWsTB@wuerfel> Hello Arnd, On 01/02/2017 02:10 PM, Arnd Bergmann wrote: > On Monday, January 2, 2017 2:06:56 PM CET Javier Martinez Canillas wrote: >> >> This small series contains a couple of cleanups that removes some driver's code >> that isn't needed due the driver being for a DT-only platform. >> >> The changes were suggested by Arnd Bergmann as a response to a previous patch: >> https://lkml.org/lkml/2017/1/2/342 >> >> Patch #1 allows the driver to be built when the COMPILE_TEST option is enabled. >> Patch #2 removes the platform ID table since isn't needed for DT-only drivers. >> Patch #3 removes a wrapper function that's also not needed if driver is DT-only. >> >> > > Looks good, but I don't know if the first patch causes some build warnings Thanks for looking at the patches. > on non-ARM platforms, better wait at least for the 0-day build results, > and maybe build-test on x86-32 and x86-64. > I should had mentioned that I built tested for arm, arm64, x86-32 and x86-64, and saw now issues. But I agree with you that it's better to wait for the 0-day builder in case it reports issues on some platforms. > Arnd > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
next prev parent reply other threads:[~2017-01-02 17:49 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-02 17:06 Javier Martinez Canillas 2017-01-02 17:06 ` [PATCH 1/3] crypto: picoxcell - Allow driver to build COMPILE_TEST is enabled Javier Martinez Canillas 2017-01-02 17:06 ` [PATCH 2/3] crypto: picoxcell - Remove platform device ID table Javier Martinez Canillas 2017-01-02 17:06 ` [PATCH 3/3] crypto: picoxcell - Remove spacc_is_compatible() wrapper function Javier Martinez Canillas 2017-01-02 17:10 ` [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code Arnd Bergmann 2017-01-02 17:49 ` Javier Martinez Canillas [this message] 2017-01-07 15:05 ` Jamie Iles 2017-01-12 16:39 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).