From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01033C33CB1 for ; Thu, 16 Jan 2020 06:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C48EF2077B for ; Thu, 16 Jan 2020 06:53:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="nc6IvgLP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbgAPGxH (ORCPT ); Thu, 16 Jan 2020 01:53:07 -0500 Received: from mo4-p03-ob.smtp.rzone.de ([81.169.146.172]:20503 "EHLO mo4-p03-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgAPGxG (ORCPT ); Thu, 16 Jan 2020 01:53:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1579157583; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=zgxQEjrG5BmsUk2SBh3MYgSiUW2Bpqj/qNPvuxNbCXI=; b=nc6IvgLP2xhxLp0CQKykBRB1q4bPBDz4cAfj+J9a/QPik7ohakQsYXgZAcxJK5IhPn 7yD2vtNUlFP3U6o7Fxwrv3flTTIaHf1czKYM1VICGaxKoXSdoRjfHuRzTo7kZPUtBJ2V un3qPAgIVUvNAjmFU5YIQrg2SO6QlCXryYpZF44H06ohIGBI3XP2CFpvCosp7wfAK8zM 7Gh9qlEEDgXJXDJ8vdQK89xsIVdMriBSKMpzSzYCsczSt8xsplfi/3j8Z9WAdNuXE2QC vJX9k49wkQI1aNtmXhmrmj0JpNZjkCoFTcDPZVw9DfbdzZHI3IsZahrLmRozKlwpFz/f iaWQ== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXPZJPScHivh" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 46.1.4 DYNA|AUTH) with ESMTPSA id u04585w0G6pjaAI (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 16 Jan 2020 07:51:45 +0100 (CET) From: Stephan Mueller To: Randy Dunlap Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, LKML , linux-api@vger.kernel.org, "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Andy Lutomirski , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman , Julia Lawall , Dan Carpenter Subject: Re: [PATCH v28 09/12] LRNG - add Jitter RNG fast noise source Date: Thu, 16 Jan 2020 07:51:45 +0100 Message-ID: <6364272.m6LlNysOQA@tauon.chronox.de> In-Reply-To: References: <6157374.ptSnyUpaCn@positron.chronox.de> <2704719.5neY5jeiZ3@positron.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Donnerstag, 16. Januar 2020, 01:17:05 CET schrieb Randy Dunlap: Hi Randy, > On 1/15/20 2:34 AM, Stephan M=FCller wrote: > > CC: "Eric W. Biederman" > > CC: "Alexander E. Patrakov" > > CC: "Ahmed S. Darwish" > > CC: "Theodore Y. Ts'o" > > CC: Willy Tarreau > > CC: Matthew Garrett > > CC: Vito Caputo > > CC: Andreas Dilger > > CC: Jan Kara > > CC: Ray Strode > > CC: William Jon McCann > > CC: zhangjs > > CC: Andy Lutomirski > > CC: Florian Weimer > > CC: Lennart Poettering > > CC: Nicolai Stange > > Reviewed-by: Marcelo Henrique Cerri > > Reviewed-by: Roman Drahtmueller > > Tested-by: Roman Drahtm=FCller > > Tested-by: Marcelo Henrique Cerri > > Tested-by: Neil Horman > > Signed-off-by: Stephan Mueller > > --- > >=20 > > drivers/char/lrng/Kconfig | 11 +++++ > > drivers/char/lrng/Makefile | 1 + > > drivers/char/lrng/lrng_jent.c | 89 +++++++++++++++++++++++++++++++++++ > > 3 files changed, 101 insertions(+) > > create mode 100644 drivers/char/lrng/lrng_jent.c > >=20 > > diff --git a/drivers/char/lrng/Kconfig b/drivers/char/lrng/Kconfig > > index 0d070a3897dd..10b7cbdb8c8e 100644 > > --- a/drivers/char/lrng/Kconfig > > +++ b/drivers/char/lrng/Kconfig > > @@ -92,4 +92,15 @@ config LRNG_KCAPI > >=20 > > provided by the selected kernel crypto API RNG. > > =20 > > endif # LRNG_DRNG_SWITCH > >=20 > > +config LRNG_JENT > > + bool "Enable Jitter RNG as LRNG Seed Source" > > + select CRYPTO_JITTERENTROPY >=20 > Don't select unless CRYPTO is already set/enabled. I added "depends on=20 >=20 > > + help > > + The Linux RNG may use the Jitter RNG as noise source. Enabling > > + this option enables the use of the Jitter RNG. Its default > > + entropy level is 16 bits of entropy per 256 data bits delivered > > + by the Jitter RNG. This entropy level can be changed at boot > > + time or at runtime with the lrng_base.jitterrng configuration > > + variable. > > + > >=20 > > endif # LRNG > >=20 > > diff --git a/drivers/char/lrng/lrng_jent.c b/drivers/char/lrng/lrng_jen= t.c > > new file mode 100644 > > index 000000000000..ff0bbe2680c4 > > --- /dev/null > > +++ b/drivers/char/lrng/lrng_jent.c > > @@ -0,0 +1,89 @@ > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > > +/* > > + * LRNG Fast Noise Source: Jitter RNG > > + * > > + * Copyright (C) 2016 - 2020, Stephan Mueller > > + */ > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > + > > +#include > > +#include > > + > > +#include "lrng_internal.h" > > + > > +/* > > + * Estimated entropy of data is a 16th of > > LRNG_DRNG_SECURITY_STRENGTH_BITS. + * Albeit a full entropy assessment = is > > provided for the noise source indicating + * that it provides high > > entropy rates and considering that it deactivates + * when it detects > > insufficient hardware, the chosen under estimation of + * entropy is > > considered to be acceptable to all reviewers. > > + */ > > +static u32 jitterrng =3D LRNG_DRNG_SECURITY_STRENGTH_BITS>>4; > > +module_param(jitterrng, uint, 0644); > > +MODULE_PARM_DESC(jitterrng, "Entropy in bits of 256 data bits from Jit= ter > > " + "RNG noise source"); >=20 > One line for the string, please, not split to 2 lines. Changed. Thank you. Ciao Stephan