From: <Christian.Gromm@microchip.com>
To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <linux-x25@vger.kernel.org>, <ms@dev.tdt.de>, <mpm@selenic.com>,
<linux@armlinux.org.uk>, <wireguard@lists.zx2c4.com>,
<Jason@zx2c4.com>, <khc@pm.waw.pl>, <kuba@kernel.org>,
<dilinger@queued.net>, <linux-arm-kernel@lists.infradead.org>,
<gregkh@linuxfoundation.org>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <arnd@arndb.de>,
<herbert@gondor.apana.org.au>, <linux-geode@lists.infradead.org>,
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific
Date: Mon, 19 Jul 2021 06:45:35 +0000 [thread overview]
Message-ID: <787d71b4cb5174bda5a35d5ea44777d994b85e59.camel@microchip.com> (raw)
In-Reply-To: <20210711223148.5250-5-rdunlap@infradead.org>
On Sun, 2021-07-11 at 15:31 -0700, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Rename module_init & module_exit functions that are named
> "mod_init" and "mod_exit" so that they are unique in both the
> System.map file and in initcall_debug output instead of showing
> up as almost anonymous "mod_init".
>
> This is helpful for debugging and in determining how long certain
> module_init calls take to execute.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christian Gromm <christian.gromm@microchip.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2: no change
>
> drivers/most/most_cdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20210708.orig/drivers/most/most_cdev.c
> +++ linux-next-20210708/drivers/most/most_cdev.c
> @@ -486,7 +486,7 @@ static struct cdev_component comp = {
> },
> };
>
> -static int __init mod_init(void)
> +static int __init most_cdev_init(void)
> {
> int err;
>
> @@ -518,7 +518,7 @@ dest_ida:
> return err;
> }
>
> -static void __exit mod_exit(void)
> +static void __exit most_cdev_exit(void)
> {
> struct comp_channel *c, *tmp;
>
> @@ -534,8 +534,8 @@ static void __exit mod_exit(void)
> class_destroy(comp.class);
> }
>
> -module_init(mod_init);
> -module_exit(mod_exit);
> +module_init(most_cdev_init);
> +module_exit(most_cdev_exit);
> MODULE_AUTHOR("Christian Gromm <christian.gromm@microchip.com>");
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("character device component for mostcore");
Acked-by: Christian Gromm (christian.gromm@microchip.com)
next prev parent reply other threads:[~2021-07-19 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 22:31 [PATCH 0/6 v2] treewide: rename 'mod_init' & 'mod_exit' functions to be module-specific Randy Dunlap
2021-07-11 22:31 ` [PATCH 1/6 v2] arm: crypto: " Randy Dunlap
2021-07-11 22:31 ` [PATCH 2/6 v2] hw_random: " Randy Dunlap
2021-07-11 22:31 ` [PATCH 3/6 v2] lib: crypto: " Randy Dunlap
2021-07-11 22:31 ` [PATCH 4/6 v2] MOST: cdev: " Randy Dunlap
2021-07-19 6:45 ` Christian.Gromm [this message]
2021-07-11 22:31 ` [PATCH 5/6 v2] net: hdlc: " Randy Dunlap
2021-07-19 5:45 ` Krzysztof Hałasa
2021-07-11 22:31 ` [PATCH 6/6 v2] wireguard: main: " Randy Dunlap
2021-08-08 20:22 ` Jason A. Donenfeld
2021-07-16 8:15 ` [PATCH 0/6 v2] treewide: " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787d71b4cb5174bda5a35d5ea44777d994b85e59.camel@microchip.com \
--to=christian.gromm@microchip.com \
--cc=Jason@zx2c4.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dilinger@queued.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mpm@selenic.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).