From: "Zeng, Xin" <xin.zeng@intel.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: "Xuquan \(Quan Xu\)" <xuquan8@huawei.com>,
"Huangweidong \(C\)" <weidong.huang@huawei.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"Hanweidong \(Randy\)" <hanweidong@huawei.com>,
Claudio Fontana <Claudio.Fontana@huawei.com>,
"mst@redhat.com" <mst@redhat.com>,
Luonengjun <luonengjun@huawei.com>,
"Wanzongshun \(Vincent\)" <wanzongshun@huawei.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"Zhoujian \(jay, Euler\)" <jianjay.zhou@huawei.com>,
longpeng <longpeng2@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Wubin \(H\)" <wu.wubin@huawei.com>,
"arei.gonglei@hotmail.com" <arei.gonglei@hotmail.com>
Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver
Date: Thu, 15 Dec 2016 00:59:19 +0000 [thread overview]
Message-ID: <82063967A54EF84C8AFCD6BD7F6AD93310C14374@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020DA163033@DGGEMA505-MBX.china.huawei.com>
On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote:
< > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c
< > b/drivers/crypto/virtio/virtio_crypto_core.c
< > > new file mode 100644
< > > index 0000000..c0854a1
< > > --- /dev/null
< > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c
< > > @@ -0,0 +1,474 @@
< > [..]
< > > +
< > > +static void virtcrypto_dataq_callback(struct virtqueue *vq)
< > > +{
< > > + struct virtio_crypto *vcrypto = vq->vdev->priv;
< > > + struct virtio_crypto_request *vc_req;
< > > + unsigned long flags;
< > > + unsigned int len;
< > > + struct ablkcipher_request *ablk_req;
< > > + int error;
< > > +
< > > + spin_lock_irqsave(&vcrypto->lock, flags);
< >
< > Would it make sense to use a per virtqueue lock
< > like in virtio_blk for example instead of locking on the whole
< > device? OK, it seems you use only one dataqueue, so it
< > may not be that relevant.
< >
< Currently yes, both the backend device (cryptodev-backend-builtin)
< and the frontend driver use one dataqueue.
<
I think it makes sense to use per virtqueue lock here though it only uses one queue so far,
but in the spec we already have multi queues support.
< Regards,
< -Gonglei
next prev parent reply other threads:[~2016-12-15 0:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 11:50 [PATCH v7 0/1] virtio-crypto: add Linux driver Gonglei
2016-12-14 11:50 ` [PATCH v7 1/1] crypto: add virtio-crypto driver Gonglei
2016-12-14 15:38 ` [Qemu-devel] " Halil Pasic
2016-12-15 0:45 ` Gonglei (Arei)
2016-12-15 0:59 ` Zeng, Xin [this message]
2016-12-15 1:08 ` Gonglei (Arei)
2016-12-15 16:42 ` Michael S. Tsirkin
2016-12-16 0:40 ` [virtio-dev] " Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82063967A54EF84C8AFCD6BD7F6AD93310C14374@SHSMSX103.ccr.corp.intel.com \
--to=xin.zeng@intel.com \
--cc=Claudio.Fontana@huawei.com \
--cc=arei.gonglei@hotmail.com \
--cc=arei.gonglei@huawei.com \
--cc=davem@davemloft.net \
--cc=hanweidong@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=jianjay.zhou@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wanzongshun@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=wu.wubin@huawei.com \
--cc=xuquan8@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).