linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Eric Biggers <ebiggers@kernel.org>,
	Nayna <nayna@linux.vnet.ibm.com>,
	leo.barbosa@canonical.com, Stephan Mueller <smueller@chronox.de>,
	nayna@linux.ibm.com, omosnacek@gmail.com, leitao@debian.org,
	pfsmorigo@gmail.com, linux-crypto@vger.kernel.org,
	marcelo.cerri@canonical.com,
	George Wilson <gcwilson@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] crypto: vmx - fix copy-paste error in CTR mode
Date: Wed, 15 May 2019 16:36:12 +1000	[thread overview]
Message-ID: <874l5w1axv.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <20190515035336.y42wzhs3wzqdpwzn@gondor.apana.org.au>

Herbert Xu <herbert@gondor.apana.org.au> writes:

> On Wed, May 15, 2019 at 03:35:51AM +1000, Daniel Axtens wrote:
>>
>> By all means disable vmx ctr if I don't get an answer to you in a
>> timeframe you are comfortable with, but I am going to at least try to
>> have a look.
>
> I'm happy to give you guys more time.  How much time do you think
> you will need?
>
Give me till the end of the week: if I haven't solved it by then I will
probably have to give up and go on to other things anyway.

(FWIW, it seems to happen when encoding greater than 4 but less than 8
AES blocks - in particular with both 7 and 5 blocks encoded I can see it
go wrong from block 4 onwards. No idea why yet, and the asm is pretty
dense, but that's where I'm at at the moment.)

Regards,
Daniel

> Thanks,
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2019-05-15  6:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15  2:09 [PATCH] crypto: vmx - fix copy-paste error in CTR mode Daniel Axtens
2019-03-15  2:24 ` Eric Biggers
2019-03-15  4:24   ` Daniel Axtens
2019-03-15  4:34     ` Eric Biggers
2019-03-15  5:23       ` Daniel Axtens
2019-04-10  7:02         ` Eric Biggers
2019-04-11 14:47           ` Daniel Axtens
2019-04-11 17:40             ` Nayna
2019-04-13  3:41               ` Michael Ellerman
2019-05-06 15:53                 ` Eric Biggers
2019-05-13  0:59                   ` Herbert Xu
2019-05-13 11:39                     ` Michael Ellerman
2019-05-14 17:35                       ` Daniel Axtens
2019-05-15  3:53                         ` Herbert Xu
2019-05-15  6:36                           ` Daniel Axtens [this message]
2019-05-16  2:12                             ` Daniel Axtens
2019-05-16  2:56                               ` Eric Biggers
2019-05-16  5:28                                 ` Daniel Axtens
2019-03-18  8:41       ` Michael Ellerman
2019-03-18  9:13         ` Ard Biesheuvel
2019-03-19  0:52           ` Michael Ellerman
2019-03-18  6:03 ` Michael Ellerman
2019-03-20  8:40 ` Ondrej Mosnáček
2019-03-22 13:04 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l5w1axv.fsf@dja-thinkpad.axtens.net \
    --to=dja@axtens.net \
    --cc=ebiggers@kernel.org \
    --cc=gcwilson@linux.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=leitao@debian.org \
    --cc=leo.barbosa@canonical.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    --cc=nayna@linux.vnet.ibm.com \
    --cc=omosnacek@gmail.com \
    --cc=pfsmorigo@gmail.com \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).