From: John Garry <john.garry@huawei.com>
To: Xu Zaibo <xuzaibo@huawei.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>
Cc: <qianweili@huawei.com>, <tanghui20@huawei.com>,
<forest.zhouchang@huawei.com>, <linuxarm@huawei.com>,
<zhangwei375@huawei.com>, <shenyang39@huawei.com>,
<yekai13@huawei.com>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 4/4] crypto: hisilicon/sec2 - Add pbuffer mode for SEC driver
Date: Thu, 20 Feb 2020 11:07:08 +0000 [thread overview]
Message-ID: <87591c1f-5c6b-64bd-5dc2-900e1481b5ca@huawei.com> (raw)
In-Reply-To: <69fe2d60-428e-9747-b7c0-d69cf25efc0e@huawei.com>
On 20/02/2020 10:10, Xu Zaibo wrote:
> Hi,
>
>
> On 2020/2/20 17:50, John Garry wrote:
>> On 20/02/2020 09:04, Zaibo Xu wrote:
>>> From: liulongfang <liulongfang@huawei.com>
>>>
>>> In the scenario of SMMU translation, the SEC performance of short
>>> messages
>>> (<512Bytes) cannot meet our expectations. To avoid this, we reserve the
>>> plat buffer (PBUF) memory for small packets when creating TFM.
>>>
>>
>> I haven't gone through the code here, but why not use this method also
>> for non-translated? What are the pros and cons?
> Because non-translated has no performance or throughput problems.
>
OK, so no problem, but I was asking could it be improved, and, if so,
what would be the drawbacks?
As for the change to check if the IOMMU is translating, it seems exact
same as that for the hi1616 driver...
> cheers,
> Zaibo
>
> .
>>
>> The commit message is very light on details.
>>
>> Thanks
>> john
>>
>> .
>>
>
>
> .
next prev parent reply other threads:[~2020-02-20 11:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 9:04 [PATCH 0/4] crypto: hisilicon - Improve SEC performance Zaibo Xu
2020-02-20 9:04 ` [PATCH 1/4] crypto: hisilicon - Use one workqueue per qm instead of per qp Zaibo Xu
2020-02-20 9:04 ` [PATCH 2/4] crypto: hisilicon/sec2 - Add workqueue for SEC driver Zaibo Xu
2020-02-20 9:04 ` [PATCH 3/4] crypto: hisilicon/sec2 - Add iommu status check Zaibo Xu
2020-02-20 9:04 ` [PATCH 4/4] crypto: hisilicon/sec2 - Add pbuffer mode for SEC driver Zaibo Xu
2020-02-20 9:50 ` John Garry
2020-02-20 10:10 ` Xu Zaibo
2020-02-20 11:07 ` John Garry [this message]
2020-02-20 12:16 ` Xu Zaibo
2020-02-20 12:20 ` John Garry
2020-02-20 12:32 ` Xu Zaibo
2020-02-24 14:01 ` Jonathan Cameron
2020-02-25 3:16 ` Xu Zaibo
2020-02-25 15:14 ` Jonathan Cameron
2020-02-26 11:18 ` Xu Zaibo
2020-02-26 14:30 ` Jonathan Cameron
2020-02-27 1:13 ` Xu Zaibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87591c1f-5c6b-64bd-5dc2-900e1481b5ca@huawei.com \
--to=john.garry@huawei.com \
--cc=davem@davemloft.net \
--cc=forest.zhouchang@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=qianweili@huawei.com \
--cc=shenyang39@huawei.com \
--cc=tanghui20@huawei.com \
--cc=xuzaibo@huawei.com \
--cc=yekai13@huawei.com \
--cc=zhangwei375@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).