From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103A8C4332E for ; Fri, 20 Mar 2020 20:30:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E359B20777 for ; Fri, 20 Mar 2020 20:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727152AbgCTUa4 (ORCPT ); Fri, 20 Mar 2020 16:30:56 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:37098 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726789AbgCTUa4 (ORCPT ); Fri, 20 Mar 2020 16:30:56 -0400 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jFOHm-0003TQ-I5; Fri, 20 Mar 2020 21:30:30 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id E29761039FC; Fri, 20 Mar 2020 21:30:29 +0100 (CET) From: Thomas Gleixner To: Andy Shevchenko Cc: LKML , "maintainer\:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Greg Kroah-Hartman , Mark Gross , Tony Luck , "Rafael J. Wysocki" , Viresh Kumar , Linux PM , Srinivas Pandruvada , Len Brown , Paolo Bonzini , Darren Hart , Andy Shevchenko , ACPI Devel Maling List , linux-edac@vger.kernel.org, Platform Driver , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Zhang Rui , Daniel Lezcano , Amit Kucheria , Chanwoo Choi , Jacob Pan , Adrian Hunter , Ulf Hansson , linux-mmc , Bjorn Helgaas , linux-pci@vger.kernel.org, Takashi Iwai , ALSA Development Mailing List , Herbert Xu , "David S. Miller" , linux-crypto Subject: Re: [patch 09/22] cpufreq: Convert to new X86 CPU match macros In-Reply-To: References: <20200320131345.635023594@linutronix.de> <20200320131509.564059710@linutronix.de> Date: Fri, 20 Mar 2020 21:30:29 +0100 Message-ID: <87eetmpy56.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Andy Shevchenko writes: > On Fri, Mar 20, 2020 at 3:18 PM Thomas Gleixner wrote: > >> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6, 9, X86_FEATURE_EST, NULL), >> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6, 13, X86_FEATURE_EST, NULL), >> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 15, 3, X86_FEATURE_EST, NULL), >> + X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 15, 4, X86_FEATURE_EST, NULL), > >> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0x8, 0), >> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0xb, 0), >> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 15, 0x2, 0), > >> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0x8, 0), >> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, 0xb, 0), >> + X86_MATCH_VENDOR_FAM_MODEL(INTEL, 15, 0x2, 0), > > Perhaps use names instead of 6 and 15? Thought about that and did not come up with anyting useful. FAM6 vs. 6 is not really any better > Also, NULL vs. 0? Both works, but yes I used mostly NULL. Thanks, tglx