From: Daniel Axtens <dja@axtens.net>
To: Haren Myneni <haren@linux.ibm.com>,
herbert@gondor.apana.org.au, mpe@ellerman.id.au
Cc: mikey@neuling.org, sukadev@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org,
npiggin@gmail.com
Subject: Re: [PATCH v3 0/9] crypto/nx: Enable GZIP engine and provide userpace API
Date: Tue, 17 Mar 2020 00:04:02 +1100 [thread overview]
Message-ID: <87y2s0o3i5.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <1583540877.9256.24.camel@hbabu-laptop>
Hi Haren,
If I understand correctly, to test these, I need to apply both this
series and your VAS userspace page fault handling series - is that
right?
Kind regards,
Daniel
> Power9 processor supports Virtual Accelerator Switchboard (VAS) which
> allows kernel and userspace to send compression requests to Nest
> Accelerator (NX) directly. The NX unit comprises of 2 842 compression
> engines and 1 GZIP engine. Linux kernel already has 842 compression
> support on kernel. This patch series adds GZIP compression support
> from user space. The GZIP Compression engine implements the ZLIB and
> GZIP compression algorithms. No plans of adding NX-GZIP compression
> support in kernel right now.
>
> Applications can send requests to NX directly with COPY/PASTE
> instructions. But kernel has to establish channel / window on NX-GZIP
> device for the userspace. So userspace access to the GZIP engine is
> provided through /dev/crypto/nx-gzip device with several operations.
>
> An application must open the this device to obtain a file descriptor (fd).
> Using the fd, application should issue the VAS_TX_WIN_OPEN ioctl to
> establish a connection to the engine. Once window is opened, should use
> mmap() system call to map the hardware address of engine's request queue
> into the application's virtual address space. Then user space forms the
> request as co-processor Request Block (CRB) and paste this CRB on the
> mapped HW address using COPY/PASTE instructions. Application can poll
> on status flags (part of CRB) with timeout for request completion.
>
> For VAS_TX_WIN_OPEN ioctl, if user space passes vas_id = -1 (struct
> vas_tx_win_open_attr), kernel determines the VAS instance on the
> corresponding chip based on the CPU on which the process is executing.
> Otherwise, the specified VAS instance is used if application passes the
> proper VAS instance (vas_id listed in /proc/device-tree/vas@*/ibm,vas_id).
>
> Process can open multiple windows with different FDs or can send several
> requests to NX on the same window at the same time.
>
> A userspace library libnxz is available:
> https://github.com/abalib/power-gzip
>
> Applications that use inflate/deflate calls can link with libNXz and use
> NX GZIP compression without any modification.
>
> Tested the available 842 compression on power8 and power9 system to make
> sure no regression and tested GZIP compression on power9 with tests
> available in the above link.
>
> Thanks to Bulent Abali for nxz library and tests development.
>
> Changelog:
> V2:
> - Move user space API code to powerpc as suggested. Also this API
> can be extended to any other coprocessor type that VAS can support
> in future. Example: Fast thread wakeup feature from VAS
> - Rebased to 5.6-rc3
>
> V3:
> - Fix sparse warnings (patches 3&6)
>
> Haren Myneni (9):
> powerpc/vas: Initialize window attributes for GZIP coprocessor type
> powerpc/vas: Define VAS_TX_WIN_OPEN ioctl API
> powerpc/vas: Add VAS user space API
> crypto/nx: Initialize coproc entry with kzalloc
> crypto/nx: Rename nx-842-powernv file name to nx-common-powernv
> crypto/NX: Make enable code generic to add new GZIP compression type
> crypto/nx: Enable and setup GZIP compresstion type
> crypto/nx: Remove 'pid' in vas_tx_win_attr struct
> Documentation/powerpc: VAS API
>
> Documentation/powerpc/index.rst | 1 +
> Documentation/powerpc/vas-api.rst | 246 +++++
> Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
> arch/powerpc/include/asm/vas.h | 12 +-
> arch/powerpc/include/uapi/asm/vas-api.h | 22 +
> arch/powerpc/platforms/powernv/Makefile | 2 +-
> arch/powerpc/platforms/powernv/vas-api.c | 290 +++++
> arch/powerpc/platforms/powernv/vas-window.c | 23 +-
> arch/powerpc/platforms/powernv/vas.h | 2 +
> drivers/crypto/nx/Makefile | 2 +-
> drivers/crypto/nx/nx-842-powernv.c | 1062 ------------------
> drivers/crypto/nx/nx-common-powernv.c | 1133 ++++++++++++++++++++
> 12 files changed, 1723 insertions(+), 1073 deletions(-)
> create mode 100644 Documentation/powerpc/vas-api.rst
> create mode 100644 arch/powerpc/include/uapi/asm/vas-api.h
> create mode 100644 arch/powerpc/platforms/powernv/vas-api.c
> delete mode 100644 drivers/crypto/nx/nx-842-powernv.c
> create mode 100644 drivers/crypto/nx/nx-common-powernv.c
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2020-03-16 13:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 0:27 [PATCH v3 0/9] crypto/nx: Enable GZIP engine and provide userpace API Haren Myneni
2020-03-07 0:32 ` [PATCH v3 1/9] powerpc/vas: Initialize window attributes for GZIP coprocessor type Haren Myneni
2020-03-07 0:32 ` [PATCH v3 2/9] powerpc/vas: Define VAS_TX_WIN_OPEN ioctl API Haren Myneni
2020-03-07 0:33 ` [PATCH v3 3/9] powerpc/vas: Add VAS user space API Haren Myneni
2020-03-18 7:12 ` Daniel Axtens
2020-03-19 1:16 ` Daniel Axtens
2020-03-19 1:53 ` Haren Myneni
2020-03-20 12:18 ` Daniel Axtens
2020-03-22 20:50 ` Haren Myneni
2020-03-07 0:34 ` [PATCH v3 4/9] crypto/nx: Initialize coproc entry with kzalloc Haren Myneni
2020-03-07 0:34 ` [PATCH v3 5/9] crypto/nx: Rename nx-842-powernv file name to nx-common-powernv Haren Myneni
2020-03-07 0:36 ` [PATCH v3 6/9] crypto/NX: Make enable code generic to add new GZIP compression type Haren Myneni
2020-03-07 0:37 ` [PATCH v3 7/9] crypto/nx: Enable and setup GZIP compresstion type Haren Myneni
2020-03-07 0:38 ` [PATCH v3 8/9] crypto/nx: Remove 'pid' in vas_tx_win_attr struct Haren Myneni
2020-03-07 0:39 ` [PATCH v3 9/9] Documentation/powerpc: VAS API Haren Myneni
2020-03-20 12:24 ` Daniel Axtens
2020-03-23 0:54 ` Haren Myneni
2020-03-23 8:32 ` Nicholas Piggin
2020-03-16 13:04 ` Daniel Axtens [this message]
2020-03-16 23:31 ` [PATCH v3 0/9] crypto/nx: Enable GZIP engine and provide userpace API Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2s0o3i5.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=haren@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).