From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org,
Herbert Xu <herberg@gondor.apana.org.au>,
David Miller <davem@davemloft.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 10/12] nvmet: Implement basic In-Band Authentication
Date: Mon, 22 Nov 2021 16:00:13 +0200 [thread overview]
Message-ID: <891fe077-40d3-5bad-52fb-f0ee6f6107b6@grimberg.me> (raw)
In-Reply-To: <313b19d2-ea54-ce1c-f9cb-3f1fb6743787@suse.de>
On 11/22/21 3:21 PM, Hannes Reinecke wrote:
> On 11/22/21 12:59 PM, Sagi Grimberg wrote:
>>
>>> +void nvmet_execute_auth_send(struct nvmet_req *req)
>>> +{
>>> + struct nvmet_ctrl *ctrl = req->sq->ctrl;
>>> + struct nvmf_auth_dhchap_success2_data *data;
>>> + void *d;
>>> + u32 tl;
>>> + u16 status = 0;
>>> +
>>> + if (req->cmd->auth_send.secp !=
>>> NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER) {
>>> + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR;
>>> + req->error_loc =
>>> + offsetof(struct nvmf_auth_send_command, secp);
>>> + goto done;
>>> + }
>>> + if (req->cmd->auth_send.spsp0 != 0x01) {
>>> + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR;
>>> + req->error_loc =
>>> + offsetof(struct nvmf_auth_send_command, spsp0);
>>> + goto done;
>>> + }
>>> + if (req->cmd->auth_send.spsp1 != 0x01) {
>>> + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR;
>>> + req->error_loc =
>>> + offsetof(struct nvmf_auth_send_command, spsp1);
>>> + goto done;
>>> + }
>>> + tl = le32_to_cpu(req->cmd->auth_send.tl);
>>> + if (!tl) {
>>> + status = NVME_SC_INVALID_FIELD | NVME_SC_DNR;
>>> + req->error_loc =
>>> + offsetof(struct nvmf_auth_send_command, tl);
>>> + goto done;
>>> + }
>>> + if (!nvmet_check_transfer_len(req, tl)) {
>>> + pr_debug("%s: transfer length mismatch (%u)\n", __func__, tl);
>>> + return;
>>> + }
>>> +
>>> + d = kmalloc(tl, GFP_KERNEL);
>>> + if (!d) {
>>> + status = NVME_SC_INTERNAL;
>>> + goto done;
>>> + }
>>> +
>>> + status = nvmet_copy_from_sgl(req, 0, d, tl);
>>> + if (status) {
>>> + kfree(d);
>>> + goto done;
>>> + }
>>> +
>>> + data = d;
>>> + pr_debug("%s: ctrl %d qid %d type %d id %d step %x\n", __func__,
>>> + ctrl->cntlid, req->sq->qid, data->auth_type, data->auth_id,
>>> + req->sq->dhchap_step);
>>> + if (data->auth_type != NVME_AUTH_COMMON_MESSAGES &&
>>> + data->auth_type != NVME_AUTH_DHCHAP_MESSAGES)
>>> + goto done_failure1;
>>> + if (data->auth_type == NVME_AUTH_COMMON_MESSAGES) {
>>> + if (data->auth_id == NVME_AUTH_DHCHAP_MESSAGE_NEGOTIATE) {
>>> + /* Restart negotiation */
>>> + pr_debug("%s: ctrl %d qid %d reset negotiation\n", __func__,
>>> + ctrl->cntlid, req->sq->qid);
>>> + if (!req->sq->qid) {
>>> + status = nvmet_setup_auth(ctrl);
>>
>> Aren't you leaking memory here?
>
> I've checked, and I _think_ everything is in order.
> Any particular concerns?
> ( 'd' is free at 'done_kfree', and we never exit without going through
> it AFAICS).
> Have I missed something?
You are calling nvmet_setup_auth for re-authentication, who is calling
nvmet_destroy_auth to free the controller auth stuff?
Don't you need something like:
--
if (!req->sq->qid) {
nvmet_destroy_auth(ctrl);
status = nvmet_setup_auth(ctrl);
...
}
--
next prev parent reply other threads:[~2021-11-22 14:00 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 7:47 [PATCHv6 00/12] nvme: In-band authentication support Hannes Reinecke
2021-11-22 7:47 ` [PATCH 01/12] crypto: add crypto_has_shash() Hannes Reinecke
2021-11-22 7:47 ` [PATCH 02/12] crypto: add crypto_has_kpp() Hannes Reinecke
2021-11-22 7:47 ` [PATCH 03/12] crypto/ffdhe: Finite Field DH Ephemeral Parameters Hannes Reinecke
2021-11-23 8:41 ` Chaitanya Kulkarni
2021-11-22 7:47 ` [PATCH 04/12] lib/base64: RFC4648-compliant base64 encoding Hannes Reinecke
2021-11-22 12:06 ` Sagi Grimberg
2021-11-22 7:47 ` [PATCH 05/12] nvme: add definitions for NVMe In-Band authentication Hannes Reinecke
2021-11-23 8:43 ` Chaitanya Kulkarni
2021-11-22 7:47 ` [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error Hannes Reinecke
2021-11-22 7:47 ` [PATCH 07/12] nvme: Implement In-Band authentication Hannes Reinecke
2021-11-22 8:12 ` Sagi Grimberg
2021-11-22 9:15 ` Hannes Reinecke
2021-11-23 9:02 ` Chaitanya Kulkarni
2021-11-22 7:47 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-11-22 7:47 ` [PATCH 09/12] nvmet: Parse fabrics commands on all queues Hannes Reinecke
2021-11-23 9:06 ` Chaitanya Kulkarni
2021-11-22 7:47 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-11-22 11:59 ` Sagi Grimberg
2021-11-22 12:06 ` Hannes Reinecke
2021-11-22 13:21 ` Hannes Reinecke
2021-11-22 14:00 ` Sagi Grimberg [this message]
2021-11-22 14:17 ` Hannes Reinecke
2021-11-22 14:31 ` Sagi Grimberg
2021-11-22 7:47 ` [PATCH 11/12] nvmet-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-11-22 7:47 ` [PATCH 12/12] nvmet-auth: expire authentication sessions Hannes Reinecke
2021-11-22 12:03 ` Sagi Grimberg
2021-11-22 8:13 ` [PATCHv6 00/12] nvme: In-band authentication support Sagi Grimberg
2021-11-22 9:03 ` Hannes Reinecke
2021-11-22 11:32 ` Sagi Grimberg
2021-11-22 11:37 ` Hannes Reinecke
2021-11-22 11:45 ` Sagi Grimberg
2021-11-22 11:56 ` Hannes Reinecke
2021-11-22 12:01 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2021-12-02 15:23 [PATCHv8 " Hannes Reinecke
2021-12-02 15:23 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-11-23 12:37 [PATCHv7 00/12] nvme: In-band authentication support Hannes Reinecke
2021-11-23 12:37 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-11-12 12:59 [PATCHv5 00/12] nvme: In-band authentication support Hannes Reinecke
2021-11-12 12:59 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-09-28 6:03 [PATCHv4 00/12] nvme: In-band authentication support Hannes Reinecke
2021-09-28 6:03 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-09-29 10:37 ` Sagi Grimberg
2021-09-29 12:26 ` Hannes Reinecke
2021-09-29 12:36 ` Sagi Grimberg
2021-09-29 14:32 ` Hannes Reinecke
2021-09-29 20:02 ` Sagi Grimberg
2021-09-10 6:43 [PATCHv3 00/12] nvme: In-band authentication support Hannes Reinecke
2021-09-10 6:43 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-09-26 14:30 ` Sagi Grimberg
2021-09-26 22:51 ` Sagi Grimberg
2021-09-27 6:40 ` Hannes Reinecke
2021-09-27 7:17 ` Hannes Reinecke
2021-09-27 7:55 ` Sagi Grimberg
2021-09-27 8:28 ` Hannes Reinecke
2021-09-28 22:36 ` Sagi Grimberg
2021-09-29 6:01 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=891fe077-40d3-5bad-52fb-f0ee6f6107b6@grimberg.me \
--to=sagi@grimberg.me \
--cc=davem@davemloft.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=herberg@gondor.apana.org.au \
--cc=keith.busch@wdc.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).