linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/crypto: fix %progbits -> @progbits
@ 2017-01-19 21:28 Denys Vlasenko
  2017-01-19 21:32 ` Josh Poimboeuf
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Denys Vlasenko @ 2017-01-19 21:28 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Denys Vlasenko, Josh Poimboeuf, Xiaodong Liu, Megha Dey,
	George Spelvin, linux-crypto, x86, linux-kernel

%progbits form is used on ARM (where @ is a comment char).

x86 consistently uses @progbits everywhere else.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: Josh Poimboeuf <jpoimboe@redhat.com>
CC: Xiaodong Liu <xiaodong.liu@intel.com>
CC: Megha Dey <megha.dey@intel.com>
CC: George Spelvin <linux@horizon.com>
CC: linux-crypto@vger.kernel.org
CC: x86@kernel.org
CC: linux-kernel@vger.kernel.org
---
 arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
index dc05f01..7a7de27 100644
--- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
+++ b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
@@ -312,7 +312,7 @@ do_return:
         ret
 ENDPROC(crc_pcl)
 
-.section	.rodata, "a", %progbits
+.section	.rodata, "a", @progbits
         ################################################################
         ## jump table        Table is 129 entries x 2 bytes each
         ################################################################
-- 
2.9.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86/crypto: fix %progbits -> @progbits
  2017-01-19 21:28 [PATCH] x86/crypto: fix %progbits -> @progbits Denys Vlasenko
@ 2017-01-19 21:32 ` Josh Poimboeuf
  2017-01-23 15:00 ` Herbert Xu
  2017-01-25 22:37 ` H. Peter Anvin
  2 siblings, 0 replies; 4+ messages in thread
From: Josh Poimboeuf @ 2017-01-19 21:32 UTC (permalink / raw)
  To: Denys Vlasenko
  Cc: Herbert Xu, Xiaodong Liu, Megha Dey, George Spelvin,
	linux-crypto, x86, linux-kernel

On Thu, Jan 19, 2017 at 10:28:05PM +0100, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
> 
> x86 consistently uses @progbits everywhere else.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86/crypto: fix %progbits -> @progbits
  2017-01-19 21:28 [PATCH] x86/crypto: fix %progbits -> @progbits Denys Vlasenko
  2017-01-19 21:32 ` Josh Poimboeuf
@ 2017-01-23 15:00 ` Herbert Xu
  2017-01-25 22:37 ` H. Peter Anvin
  2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-01-23 15:00 UTC (permalink / raw)
  To: Denys Vlasenko
  Cc: Josh Poimboeuf, Xiaodong Liu, Megha Dey, George Spelvin,
	linux-crypto, x86, linux-kernel

On Thu, Jan 19, 2017 at 10:28:05PM +0100, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
> 
> x86 consistently uses @progbits everywhere else.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] x86/crypto: fix %progbits -> @progbits
  2017-01-19 21:28 [PATCH] x86/crypto: fix %progbits -> @progbits Denys Vlasenko
  2017-01-19 21:32 ` Josh Poimboeuf
  2017-01-23 15:00 ` Herbert Xu
@ 2017-01-25 22:37 ` H. Peter Anvin
  2 siblings, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2017-01-25 22:37 UTC (permalink / raw)
  To: Denys Vlasenko, Herbert Xu
  Cc: Josh Poimboeuf, Xiaodong Liu, Megha Dey, George Spelvin,
	linux-crypto, x86, linux-kernel

On 01/19/17 13:28, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
> 
> x86 consistently uses @progbits everywhere else.

However, it looks like %progbits works on all architectures (at least
include/linux/init.h seems to imply so.)  Perhaps a tree-wide
replacement the other way would make more sense.

Personally I would also like to see these parameters macroized, to keep
someone from getting them wrong, just like we have __INIT, __INITRODATA
etc already, we should just have plain __TEXT __DATA __BSS...

	-hpa

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-25 22:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-19 21:28 [PATCH] x86/crypto: fix %progbits -> @progbits Denys Vlasenko
2017-01-19 21:32 ` Josh Poimboeuf
2017-01-23 15:00 ` Herbert Xu
2017-01-25 22:37 ` H. Peter Anvin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).