From: Xu Zaibo <xuzaibo@huawei.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<qianweili@huawei.com>, <tanghui20@huawei.com>,
<forest.zhouchang@huawei.com>, <linuxarm@huawei.com>,
<zhangwei375@huawei.com>, <yekai13@huawei.com>,
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] crypto: hisilicon/sec2 - Add iommu status check
Date: Tue, 3 Mar 2020 09:25:36 +0800 [thread overview]
Message-ID: <91e74cb0-0a1f-a222-68cb-745a0d5f5ea5@huawei.com> (raw)
In-Reply-To: <20200302115409.0000685e@Huawei.com>
Hi,
On 2020/3/2 19:54, Jonathan Cameron wrote:
> On Mon, 2 Mar 2020 14:15:14 +0800
> Zaibo Xu <xuzaibo@huawei.com> wrote:
>
>> From: liulongfang <liulongfang@huawei.com>
>>
>> In order to improve performance of small packets (<512Bytes)
>> in SMMU translation scenario,We need to identify the type of IOMMU
>> in the SEC probe to process small packets by a different method.
>>
>> Signed-off-by: liulongfang <liulongfang@huawei.com>
>> Reviewed-by: Zaibo Xu <xuzaibo@huawei.com>
> This looks like what we ended up with for the SECv1 driver.
Yes.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Okay
.
>> ---
>> drivers/crypto/hisilicon/sec2/sec.h | 1 +
>> drivers/crypto/hisilicon/sec2/sec_main.c | 19 +++++++++++++++++++
>> 2 files changed, 20 insertions(+)
>>
>> diff --git a/drivers/crypto/hisilicon/sec2/sec.h b/drivers/crypto/hisilicon/sec2/sec.h
>> index 13e2d8d..eab0d22 100644
>> --- a/drivers/crypto/hisilicon/sec2/sec.h
>> +++ b/drivers/crypto/hisilicon/sec2/sec.h
>> @@ -165,6 +165,7 @@ struct sec_dev {
>> struct list_head list;
>> struct sec_debug debug;
>> u32 ctx_q_num;
>> + bool iommu_used;
>> u32 num_vfs;
>> unsigned long status;
>> };
>> diff --git a/drivers/crypto/hisilicon/sec2/sec_main.c b/drivers/crypto/hisilicon/sec2/sec_main.c
>> index ebafc1c..6466d90 100644
>> --- a/drivers/crypto/hisilicon/sec2/sec_main.c
>> +++ b/drivers/crypto/hisilicon/sec2/sec_main.c
>> @@ -7,6 +7,7 @@
>> #include <linux/debugfs.h>
>> #include <linux/init.h>
>> #include <linux/io.h>
>> +#include <linux/iommu.h>
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/pci.h>
>> @@ -826,6 +827,23 @@ static void sec_probe_uninit(struct hisi_qm *qm)
>> destroy_workqueue(qm->wq);
>> }
>>
>> +static void sec_iommu_used_check(struct sec_dev *sec)
>> +{
>> + struct iommu_domain *domain;
>> + struct device *dev = &sec->qm.pdev->dev;
>> +
>> + domain = iommu_get_domain_for_dev(dev);
>> +
>> + /* Check if iommu is used */
>> + sec->iommu_used = false;
>> + if (domain) {
>> + if (domain->type & __IOMMU_DOMAIN_PAGING)
>> + sec->iommu_used = true;
>> + dev_info(dev, "SMMU Opened, the iommu type = %u\n",
>> + domain->type);
>> + }
>> +}
>> +
>> static int sec_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> {
>> struct sec_dev *sec;
>> @@ -839,6 +857,7 @@ static int sec_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> pci_set_drvdata(pdev, sec);
>>
>> sec->ctx_q_num = ctx_q_num;
>> + sec_iommu_used_check(sec);
>>
>> qm = &sec->qm;
>>
>
> .
>
next prev parent reply other threads:[~2020-03-03 1:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 6:15 [PATCH v2 0/5] crypto: hisilicon - Improve SEC performance Zaibo Xu
2020-03-02 6:15 ` [PATCH v2 1/5] crypto: hisilicon - Use one workqueue per qm instead of per qp Zaibo Xu
2020-03-02 11:39 ` Jonathan Cameron
2020-03-03 1:38 ` Xu Zaibo
2020-03-02 6:15 ` [PATCH v2 2/5] crypto: hisilicon/sec2 - Add workqueue for SEC driver Zaibo Xu
2020-03-02 11:51 ` Jonathan Cameron
2020-03-03 1:35 ` Xu Zaibo
2020-03-02 6:15 ` [PATCH v2 3/5] crypto: hisilicon/sec2 - Add iommu status check Zaibo Xu
2020-03-02 11:54 ` Jonathan Cameron
2020-03-03 1:25 ` Xu Zaibo [this message]
2020-03-03 2:16 ` Yunsheng Lin
2020-03-03 2:22 ` Xu Zaibo
2020-03-02 6:15 ` [PATCH v2 4/5] crypto: hisilicon/sec2 - Update IV and MAC operation Zaibo Xu
2020-03-02 11:58 ` Jonathan Cameron
2020-03-03 1:24 ` Xu Zaibo
2020-03-02 6:15 ` [PATCH v2 5/5] crypto: hisilicon/sec2 - Add pbuffer mode for SEC driver Zaibo Xu
2020-03-02 12:49 ` Jonathan Cameron
2020-03-03 1:22 ` Xu Zaibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91e74cb0-0a1f-a222-68cb-745a0d5f5ea5@huawei.com \
--to=xuzaibo@huawei.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=davem@davemloft.net \
--cc=forest.zhouchang@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=qianweili@huawei.com \
--cc=tanghui20@huawei.com \
--cc=yekai13@huawei.com \
--cc=zhangwei375@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).