From: Gaurav Jain <gaurav.jain@nxp.com>
To: Kun Song <Kun.Song@windriver.com>
Cc: Varun Sethi <V.Sethi@nxp.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"filip.pudak@windriver.com" <filip.pudak@windriver.com>,
"heng.guo@windriver.com" <heng.guo@windriver.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
Horia Geanta <horia.geanta@nxp.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
"richard.danter@windriver.com" <richard.danter@windriver.com>
Subject: RE: [EXT] RE: [PATCH v5.10.y] crypto: caam/jr - Fix possible caam_jr crash
Date: Thu, 11 Jan 2024 10:46:36 +0000 [thread overview]
Message-ID: <AM0PR04MB6004AECDD044F1E6BF3B6732E7682@AM0PR04MB6004.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20240110115653.3170977-1-Kun.Song@windriver.com>
> -----Original Message-----
> From: Kun Song <Kun.Song@windriver.com>
> Sent: Wednesday, January 10, 2024 5:27 PM
> To: Gaurav Jain <gaurav.jain@nxp.com>
> Cc: Kun.Song@windriver.com; Varun Sethi <V.Sethi@nxp.com>; Aymen Sghaier
> <aymen.sghaier@nxp.com>; davem@davemloft.net; filip.pudak@windriver.com;
> heng.guo@windriver.com; herbert@gondor.apana.org.au; Horia Geanta
> <horia.geanta@nxp.com>; linux-crypto@vger.kernel.org; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; richard.danter@windriver.com
> Subject: [EXT] RE: [PATCH v5.10.y] crypto: caam/jr - Fix possible caam_jr crash
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> >https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> >b.com%2Ftorvalds%2Flinux%2Fcommit%2F06e39357c36b0d3cc2779d08ed04c
> b389eaa22ba&data=05%7C02%7Cgaurav.jain%40nxp.com%7Ce1aa575fb6344e
> d3c60f08dc11d342fd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
> 638404846267170151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s
> data=x37XZurb8Lu%2BGnJtkPUeCkBnZfOROXxo6rl4XNBzM18%3D&reserved=0 -
> drivers: crypto: caam/jr - Allow quiesce when quiesced apply this one as well.
>
> Hi, Gaurav
>
> Our version has backport this
> commiti(06e39357c36b0d3cc2779d08ed04cb389eaa22ba), but the problem still
> exists.
>
> When crash occurs, the log will output
>
> <3>caam_jr 8030000.jr: Device is busy
> <3>caam_jr 8020000.jr: Device is busy
> <3>caam_jr 8010000.jr: Device is busy
> <3>caam_jr 8010000.jr: job ring error: irqstate: 00000103
I have discussed this issue internally and this is a known issue. when caam_jr_remove is exited with EBUSY, caam JR is not released.
Disabling interrupt is only avoiding the crash for the jobs sitting in input ring.
As mentioned in the commit https://github.com/torvalds/linux/commit/304a2efe9d55875c6805f3c2957bc39ceebbc5c0
jrpriv & other register are freed automatically. So any calls to JR driver via crypto api will result in crash.
Regarding this problem, discussion have happened in the past but not concluded.
I will reinitiate the discussion to have a proper fix and will add you as well.
Regards
Gaurav Jain
>
>
> Thanks!
> BR/SK
next prev parent reply other threads:[~2024-01-11 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 9:32 [PATCH v5.10.y] crypto: caam/jr - Fix possible caam_jr crash Kun Song
2023-12-22 11:43 ` Gaurav Jain (OSS)
2023-12-25 3:05 ` Kun Song
2024-01-10 1:39 ` [REMINDER] " Kun Song
2024-01-10 6:57 ` Gaurav Jain (OSS)
2024-01-10 7:00 ` Gaurav Jain
2024-01-10 8:25 ` Kun Song
2024-01-10 9:14 ` [EXT] " Gaurav Jain
2024-01-10 11:56 ` Kun Song
2024-01-11 10:46 ` Gaurav Jain [this message]
2024-01-31 13:34 ` Horia Geanta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB6004AECDD044F1E6BF3B6732E7682@AM0PR04MB6004.eurprd04.prod.outlook.com \
--to=gaurav.jain@nxp.com \
--cc=Kun.Song@windriver.com \
--cc=V.Sethi@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=filip.pudak@windriver.com \
--cc=heng.guo@windriver.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=meenakshi.aggarwal@nxp.com \
--cc=richard.danter@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).