From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"Wangzhou (B)" <wangzhou1@hisilicon.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>
Subject: RE: [PATCH v2 1/3] crypto: permit users to specify numa node of acomp hardware
Date: Fri, 3 Jul 2020 04:36:40 +0000 [thread overview]
Message-ID: <B926444035E5E2439431908E3842AFD2552A25@DGGEMI525-MBS.china.huawei.com> (raw)
In-Reply-To: <20200703041123.GA7774@gondor.apana.org.au>
> -----Original Message-----
> From: Herbert Xu [mailto:herbert@gondor.apana.org.au]
> Sent: Friday, July 3, 2020 4:11 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>
> Cc: davem@davemloft.net; Wangzhou (B) <wangzhou1@hisilicon.com>;
> Jonathan Cameron <jonathan.cameron@huawei.com>;
> akpm@linux-foundation.org; linux-crypto@vger.kernel.org;
> linux-mm@kvack.org; linux-kernel@vger.kernel.org; Linuxarm
> <linuxarm@huawei.com>; Seth Jennings <sjenning@redhat.com>; Dan
> Streetman <ddstreet@ieee.org>; Vitaly Wool <vitaly.wool@konsulko.com>
> Subject: Re: [PATCH v2 1/3] crypto: permit users to specify numa node of
> acomp hardware
>
> On Tue, Jun 23, 2020 at 04:16:08PM +1200, Barry Song wrote:
> >
> > -void *crypto_create_tfm(struct crypto_alg *alg,
> > - const struct crypto_type *frontend)
> > +void *crypto_create_tfm_node(struct crypto_alg *alg,
> > + const struct crypto_type *frontend,
> > + int node)
> > {
> > char *mem;
> > struct crypto_tfm *tfm = NULL;
> > @@ -451,6 +452,7 @@ void *crypto_create_tfm(struct crypto_alg *alg,
> >
> > tfm = (struct crypto_tfm *)(mem + tfmsize);
> > tfm->__crt_alg = alg;
> > + tfm->node = node;
>
> Should the kzalloc also use node?
Yes, it would be nice since the tfm will mainly be accessed by CPU on the specific node.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thanks
Barry
next prev parent reply other threads:[~2020-07-03 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 4:16 [PATCH v2 0/3] crypto: allow users to specify acomp hardware from a desired NUMA node Barry Song
2020-06-23 4:16 ` [PATCH v2 1/3] crypto: permit users to specify numa node of acomp hardware Barry Song
2020-07-03 4:11 ` Herbert Xu
2020-07-03 4:36 ` Song Bao Hua (Barry Song) [this message]
2020-06-23 4:16 ` [PATCH v2 2/3] crypto: hisilicon/zip - permit users to specify NUMA node Barry Song
2020-06-23 4:16 ` [PATCH v2 3/3] mm/zswap: allocate acomp on the numa node committing acomp_req Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B926444035E5E2439431908E3842AFD2552A25@DGGEMI525-MBS.china.huawei.com \
--to=song.bao.hua@hisilicon.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=herbert@gondor.apana.org.au \
--cc=jonathan.cameron@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).