From: "Stephen Brennan" <stephen@brennan.io>
To: "Baruch Siach" <baruch@tkos.co.il>,
<linux-arm-kernel@lists.infradead.org>
Cc: <stephen@brennan.io>, "Mark Rutland" <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>,
<linux-rpi-kernel@lists.infradead.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Scott Branden" <sbranden@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ray Jui" <rjui@broadcom.com>, <linux-kernel@vger.kernel.org>,
"Eric Anholt" <eric@anholt.net>,
"Rob Herring" <robh+dt@kernel.org>,
<bcm-kernel-feedback-list@broadcom.com>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Matt Mackall" <mpm@selenic.com>, "Arnd Bergmann" <arnd@arndb.de>,
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: rng: add BCM2711 RNG compatible
Date: Tue, 19 Nov 2019 21:21:49 -0800 [thread overview]
Message-ID: <BYKH0ACN38Y1.2TRTJUY5267L4@pride> (raw)
In-Reply-To: <87ftijgnhz.fsf@tarshish>
Hi Baruch,
On Wed Nov 20, 2019 at 6:50 AM, Baruch Siach wrote:
> Hi Stephen, Stefan,
>
>
> On Wed, Nov 20 2019, Stephen Brennan wrote:
>
>
> > From: Stefan Wahren <wahrenst@gmx.net>
> >
> > The BCM2711 has a RNG200 block, so document its compatible string.
> >
> > Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> > Signed-off-by: Stephen Brennan <stephen@brennan.io>
>
>
> Isn't that duplicate of Florian's commit 6223949a1531?
>
>
> > ---
> > Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> > index c223e54452da..802523196ee5 100644
> > --- a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> > +++ b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt
> > @@ -2,6 +2,7 @@ HWRNG support for the iproc-rng200 driver
> >
> > Required properties:
> > - compatible : Must be one of:
> > + "brcm,bcm2711-rng200"
> > "brcm,bcm7211-rng200"
>
>
> Isn't this clear text duplication? Am I missing something obvious?
>
I understand the confusion, but they're different, we're looking at the
difference between:
bcm2711
bcm7211
^^
These are apparently separate but related chips, leading to confusion in
other places [1] as well. I double checked the commit 6223949a1531 you
pointed out, as well as 1fa6d053b2a5 from your other email, to verify that
this is the case. No duplication (as far as I can tell) is in the series.
[1]: https://github.com/raspberrypi/linux/issues/3163
Regards,
Stephen
>
> I was looking at versions of this patch series wondering why no one
> noticed that.
>
>
> baruch
>
>
> > "brcm,bcm7278-rng200"
> > "brcm,iproc-rng200"
>
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
>
>
>
>
next prev parent reply other threads:[~2019-11-20 5:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 3:16 [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support Stephen Brennan
2019-11-20 3:16 ` [PATCH v3 1/4] dt-bindings: rng: add BCM2711 RNG compatible Stephen Brennan
2019-11-20 4:50 ` Baruch Siach
2019-11-20 5:21 ` Stephen Brennan [this message]
2019-11-20 19:55 ` Florian Fainelli
2019-11-23 0:39 ` Rob Herring
2019-11-20 3:16 ` [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711 Stephen Brennan
2019-11-20 4:52 ` Baruch Siach
2019-11-20 17:33 ` Matthias Brugger
2019-11-20 19:55 ` Florian Fainelli
2019-11-20 3:16 ` [PATCH v3 3/4] ARM: dts: bcm2835: Move rng definition to common location Stephen Brennan
2019-11-20 16:20 ` Stefan Wahren
2019-11-20 3:16 ` [PATCH v3 4/4] ARM: dts: bcm2711: Enable HWRNG support Stephen Brennan
2019-11-20 16:21 ` Stefan Wahren
2019-11-20 19:45 ` Nicolas Saenz Julienne
2019-11-20 16:16 ` [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support Stefan Wahren
2019-11-20 19:50 ` Nicolas Saenz Julienne
2019-11-21 10:14 ` Stefan Wahren
2019-11-21 4:09 ` Florian Fainelli
2019-11-21 5:30 ` Herbert Xu
2019-12-04 4:55 ` Florian Fainelli
2019-12-04 4:59 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYKH0ACN38Y1.2TRTJUY5267L4@pride \
--to=stephen@brennan.io \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mpm@selenic.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).