From: Yangfl <mmyangfl@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, Weili Qian <qianweili@huawei.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] crypto: hisilicon/trng - add support for HiSTB TRNG
Date: Sat, 1 Apr 2023 22:05:25 +0800 [thread overview]
Message-ID: <CAAXyoMN+eVLNeiDtkwSZC2gFUDsBwn8SFST1=Nrw-qNr-u3-5w@mail.gmail.com> (raw)
In-Reply-To: <ZCfmCmxobIKaBdT4@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> 于2023年4月1日周六 16:07写道:
>
> On Fri, Mar 31, 2023 at 06:19:34PM +0800, David Yang wrote:
> >
> > + struct histb_trng_priv *priv = (struct histb_trng_priv *) rng->priv;
>
> Plesae don't use rng->priv at all. We're trying to phase it
> out because it encourages horrible casting like this.
>
> Please follow the model used in the meson driver.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Which meson driver? I didn't find any rng module under amlogic/ dir.
next prev parent reply other threads:[~2023-04-01 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 10:19 [PATCH v4] crypto: hisilicon/trng - add support for HiSTB TRNG David Yang
2023-04-01 8:06 ` Herbert Xu
2023-04-01 14:05 ` Yangfl [this message]
2023-04-03 4:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAXyoMN+eVLNeiDtkwSZC2gFUDsBwn8SFST1=Nrw-qNr-u3-5w@mail.gmail.com' \
--to=mmyangfl@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qianweili@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).