From: Chris Healy <cphealy@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-crypto@vger.kernel.org,
"Horia Geantă" <horia.geanta@nxp.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Fabio Estevam" <festevam@gmail.com>,
linux-imx@nxp.com, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam - make soc match data optional
Date: Sat, 16 May 2020 09:42:51 -0700 [thread overview]
Message-ID: <CAFXsbZoZWzD5deLfCS=rMcw80-gBcm30_3CSMm--Cc-fPSq=BA@mail.gmail.com> (raw)
In-Reply-To: <20200516042303.6070-1-andrew.smirnov@gmail.com>
With all four of Vybrid VF610, i.MX6q, i.MX6qp, and i.MX8M, this patch
caused no regressions for me. Additionally, with the VF610 and a
follow on devicetree patch, the CAAM is detected and works.
Tested by: Chris Healy <cphealy@gmail.com>
On Fri, May 15, 2020 at 9:23 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Vyrbrid devices don't have any clock that need to be taken care of, so
> make clock data optional on i.MX.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Horia Geantă <horia.geanta@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-imx@nxp.com
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/crypto/caam/ctrl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index 4fcdd262e581..6aba430793cc 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -630,12 +630,7 @@ static int caam_probe(struct platform_device *pdev)
> imx_soc_match = soc_device_match(caam_imx_soc_table);
> caam_imx = (bool)imx_soc_match;
>
> - if (imx_soc_match) {
> - if (!imx_soc_match->data) {
> - dev_err(dev, "No clock data provided for i.MX SoC");
> - return -EINVAL;
> - }
> -
> + if (imx_soc_match && imx_soc_match->data) {
> ret = init_clocks(dev, imx_soc_match->data);
> if (ret)
> return ret;
> --
> 2.21.3
next prev parent reply other threads:[~2020-05-16 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 4:23 [PATCH] crypto: caam - make soc match data optional Andrey Smirnov
2020-05-16 16:42 ` Chris Healy [this message]
2020-05-18 18:59 ` Horia Geantă
2020-05-20 3:16 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFXsbZoZWzD5deLfCS=rMcw80-gBcm30_3CSMm--Cc-fPSq=BA@mail.gmail.com' \
--to=cphealy@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).