From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4FDC433F5 for ; Wed, 12 Jan 2022 14:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241707AbiALOTl (ORCPT ); Wed, 12 Jan 2022 09:19:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241568AbiALOTj (ORCPT ); Wed, 12 Jan 2022 09:19:39 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9982DC061748 for ; Wed, 12 Jan 2022 06:19:38 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id t24so10553895edi.8 for ; Wed, 12 Jan 2022 06:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxtx.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bWDPHKiHVEi6XaHX046Gy6+jTaNRC7On6YkGQdpOLA8=; b=fBG8B/U1HhbBvtljKKjZGjGYC5ARGawtrGo2K9k9W6f5nw1Re4xMZ5XGNvkSlo1Fnh gZhIpT01ULGkRA9CBsxHYZ8oc4bNSc0cHz6cxsjfAMFy3rFztdPrOvovoBPYvvdLoWVd ZLaNVrJYnK2l/tAYlygarS3aghM1Ap8JYou9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bWDPHKiHVEi6XaHX046Gy6+jTaNRC7On6YkGQdpOLA8=; b=dpYXE6GswH4LO7xImgZRi3+wILnHkMDNepBP0XPu76Vhkz/lr9yim4LN3X5yyXmOCl DAfOsh+gm5QIJBVxJuhE0bM6BiBwJFbJuC2R8E1GEFK5rldnBiLepDf9a/K2ISk6vg1H mi8ACksQlNMUWI4McePLSjvRRXDrb48/4ZETsl6pWiNsjfHk/ajtr8oy+0AajUbr/dV6 J1R0+dOh+o6bvYuYnp9xDYcJJf55TBO/D/40q8w0XNyjatbn3iDKFw/M8ZCzwqIJTycy u1taWEjFH29OVmGglMrLMOXDNXdrVMopi3LsPJ5pf7NU1MrkLcFrku4KYTzRHLRpyfmR ofdw== X-Gm-Message-State: AOAM5339Ul82x2QZxoPFvuCzyhSFtSVKNXfPXyr7NpaBWkTkdV10UJoX kKBeLX3MiFOKJypGKGL8942BbxMDtph7/7T/nokBjA== X-Google-Smtp-Source: ABdhPJweVM/8LEIjEk4lPXPk1WktMzTKABxXOE6g/K8s1+E1cmghb68HHmZoQd3a4E1QbppCeoOK194jCvP5CMkN9sw= X-Received: by 2002:a17:907:6d1e:: with SMTP id sa30mr7947084ejc.1.1641997177124; Wed, 12 Jan 2022 06:19:37 -0800 (PST) MIME-Version: 1.0 References: <20220112140137.728162-1-jforbes@fedoraproject.org> In-Reply-To: From: Justin Forbes Date: Wed, 12 Jan 2022 08:19:26 -0600 Message-ID: Subject: Re: [PATCH v2] lib/crypto: add prompts back to crypto libraries To: "Jason A. Donenfeld" Cc: Ard Biesheuvel , Herbert Xu , "David S. Miller" , Greg Kroah-Hartman , Linux Crypto Mailing List , LKML , Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jan 12, 2022 at 8:15 AM Jason A. Donenfeld wrote: > > On Wed, Jan 12, 2022 at 3:13 PM Ard Biesheuvel wrote: > > > > On Wed, 12 Jan 2022 at 15:12, Jason A. Donenfeld wrote: > > > > > > On Wed, Jan 12, 2022 at 3:08 PM Ard Biesheuvel wrote: > > > > > > > > On Wed, 12 Jan 2022 at 15:08, Jason A. Donenfeld wrote: > > > > > > > > > > On Wed, Jan 12, 2022 at 3:06 PM Ard Biesheuvel wrote: > > > > > > > > > > > > On Wed, 12 Jan 2022 at 15:05, Jason A. Donenfeld wrote: > > > > > > > > > > > > > > This commit also needs this snippet: > > > > > > > > > > > > > > > > > > > Why? > > > > > > > > > > So that the menu of crypto library options is inside of the library > > > > > menu. Otherwise this will appear inside of the _root_ menu, which > > > > > isn't what we want. > > > > > > > > Why not? I think that's fine. > > > > > > It's really not appropriate there. Look: > > > > > > - Justin vanilla: https://i.imgur.com/14UBpML.png > > > - Justin + Jason: https://i.imgur.com/lDfZnma.png > > > > > > We really don't want another top level menu. We're not that important. > > > Rather, crypto libraries are but one ordinary subset of ordinary > > > libraries, just like how the build system does it too. > > > > I disagree. The root menu is a jumble of things already, and having > > this one at the root is really not a problem. > > Should CRC routines also go into a submenu and be put at the root? > What about other library functions? Library functions belong in the > library submenu. We don't need our own top level submenu for this. The > whole point of lib/crypto/ is that they're just boring library > functions. Libraries! So, part of the libraries menu. Specifically in this menu, users were expecting to see it in the Cryptographic API menu. I think having it in the main menu just below this entry is much more appropriate than being buried under another menu. Particularly if the goal is to get rid of the menu again all together once we can audit the full set of deps on crypto libraries. Justin