From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91CBC11D2F for ; Mon, 24 Feb 2020 16:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D6B220836 for ; Mon, 24 Feb 2020 16:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VR/V9ht7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbgBXQjR (ORCPT ); Mon, 24 Feb 2020 11:39:17 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51587 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727486AbgBXQjR (ORCPT ); Mon, 24 Feb 2020 11:39:17 -0500 Received: by mail-wm1-f67.google.com with SMTP id t23so9645030wmi.1; Mon, 24 Feb 2020 08:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M0sdWUeHuBr96/VIOIWdMJQh5Jm26LqtJhhLqkI4P9E=; b=VR/V9ht7eiYkE1kOrJhTS3S18UETRmWMnanPviE4Sdd/KzC6tw7wU5EHE9HI1rWNwF v8HHl2b0AWJFaNXX3OoheDHUt0Piu6RAX7x4lnjTIGjq5uuSkaKjMfDSa+TnSHfx40vF Nw0sfJQjmWfvOCanXcycN+b2SWmK6rUb9dG/cyGpiHQrgJvJJzcTU4CuIYVLH0ANNUF2 ATCQ3HsGEVTj2/RHrRztv2Gc0AFq3GGyPSvivAb0u4QvZjau0nr7CWBrK3lZ5BgRzhMp IqBmqodaKIHqLCGn/avqnAk82WOg2nN8FrnzkQHTWq5ou12Eqj10iauss70qgojNX2Qg 9arg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M0sdWUeHuBr96/VIOIWdMJQh5Jm26LqtJhhLqkI4P9E=; b=gRbK6CBchLq4hcIovdeJ4Q1wXEVnsfwxT8771YVBPg48U220BhaUanO0BI4O148shr GYdiswM4yT91RcHQBPYL/03TeD+2E1WhhoS7YDPbpE+J0NTm29f0FGz52mi+1680IoSE f/BWcrRUor8Su/j2Q5VMG0fvvNE1v5zXjE/5KghmsFYb9ON4iEeZcRJ/frUBcwzgv8Ox Oz6Y02OtlNrShhvP3Yt+In6+d3deU9DzU3a5kGZlGu1UvTC2J3ZhtUeL21XXQk0p+U7Q rL600ty0YfMgvVDXw5OgPzJLXf0DhR5nxKMSRHagIDkPj9rzFHH83BYoKFAJYrE/ARqN nR5A== X-Gm-Message-State: APjAAAXX8q7Xb+kWh/kZZ3ScW/PHUYU8q5vTbEtrFs77wJOrkjN5TrRg GbGH5u3G223yGTiprfz0XrEXaIL4pueQDOl+bWA= X-Google-Smtp-Source: APXvYqzGVFtlF1/ctbev1R8M6BKDpsFvi7TsUPAVaI36W478E4LcYTtrw4XOKhMNTwx+y8oTUMYDP1jkbBVmzfLMrEo= X-Received: by 2002:a05:600c:217:: with SMTP id 23mr22803384wmi.124.1582562355408; Mon, 24 Feb 2020 08:39:15 -0800 (PST) MIME-Version: 1.0 References: <20200127165646.19806-1-andrew.smirnov@gmail.com> <20200127165646.19806-4-andrew.smirnov@gmail.com> In-Reply-To: From: Andrey Smirnov Date: Mon, 24 Feb 2020 08:39:03 -0800 Message-ID: Subject: Re: [PATCH v7 3/9] crypto: caam - use devm_kzalloc to allocate JR data To: Horia Geanta Cc: "linux-crypto@vger.kernel.org" , Chris Healy , Lucas Stach , Herbert Xu , Iuliana Prodan , "linux-kernel@vger.kernel.org" , dl-linux-imx Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Feb 11, 2020 at 10:23 AM Horia Geanta wrote: > > On 1/27/2020 6:57 PM, Andrey Smirnov wrote: > > Use devm_kzalloc() to allocate JR data in order to make sure that it > > is initialized consistently every time. > > > The commit message is a bit vague. > > I assume this is needed in patch 4/9, which adds a new member (hwrng) > in caam_drv_private_jr structure. > > If so, it's probably better to have the change merged into patch 4/9. > Yes, it is specifically needed for 4/9, but it's generally a good practice to zero out allocated memory, so I made it a separate patch. Will fold it into 4/9, since that's what you prefer. Thanks, Andrey Smirnov