Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
@ 2020-03-19 18:01 Jason A. Donenfeld
  2020-03-26  4:32 ` Jason A. Donenfeld
  2020-03-27  4:55 ` Herbert Xu
  0 siblings, 2 replies; 7+ messages in thread
From: Jason A. Donenfeld @ 2020-03-19 18:01 UTC (permalink / raw)
  To: linux-crypto; +Cc: Jason A. Donenfeld, Emil Renner Berthing, Ard Biesheuvel

The .S_shipped yields a .S, and the pattern in these directories is to
add that to .gitignore so that git-status doesn't raise a fuss.

Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Reported-by: Emil Renner Berthing <kernel@esmil.dk>
Cc: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/arm/crypto/.gitignore   | 1 +
 arch/arm64/crypto/.gitignore | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/crypto/.gitignore b/arch/arm/crypto/.gitignore
index 31e1f538df7d..a3c7ad52a469 100644
--- a/arch/arm/crypto/.gitignore
+++ b/arch/arm/crypto/.gitignore
@@ -1,3 +1,4 @@
 aesbs-core.S
 sha256-core.S
 sha512-core.S
+poly1305-core.S
diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
index 879df8781ed5..e403b1343328 100644
--- a/arch/arm64/crypto/.gitignore
+++ b/arch/arm64/crypto/.gitignore
@@ -1,2 +1,3 @@
 sha256-core.S
 sha512-core.S
+poly1305-core.S
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
  2020-03-19 18:01 [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files Jason A. Donenfeld
@ 2020-03-26  4:32 ` Jason A. Donenfeld
  2020-03-26  4:38   ` Herbert Xu
  2020-03-27  4:55 ` Herbert Xu
  1 sibling, 1 reply; 7+ messages in thread
From: Jason A. Donenfeld @ 2020-03-26  4:32 UTC (permalink / raw)
  To: Linux Crypto Mailing List; +Cc: Herbert Xu

I think this might have slipped through the cracks?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
  2020-03-26  4:32 ` Jason A. Donenfeld
@ 2020-03-26  4:38   ` Herbert Xu
  2020-03-26  4:39     ` Jason A. Donenfeld
  0 siblings, 1 reply; 7+ messages in thread
From: Herbert Xu @ 2020-03-26  4:38 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: Linux Crypto Mailing List

On Wed, Mar 25, 2020 at 10:32:41PM -0600, Jason A. Donenfeld wrote:
> I think this might have slipped through the cracks?

It's on the list:

	https://patchwork.kernel.org/project/linux-crypto/list/

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
  2020-03-26  4:38   ` Herbert Xu
@ 2020-03-26  4:39     ` Jason A. Donenfeld
  0 siblings, 0 replies; 7+ messages in thread
From: Jason A. Donenfeld @ 2020-03-26  4:39 UTC (permalink / raw)
  To: Herbert Xu; +Cc: Linux Crypto Mailing List

On Wed, Mar 25, 2020 at 10:39 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Wed, Mar 25, 2020 at 10:32:41PM -0600, Jason A. Donenfeld wrote:
> > I think this might have slipped through the cracks?
>
> It's on the list:
>
>         https://patchwork.kernel.org/project/linux-crypto/list/

Oooo! Had no idea you used Patchwork. Thanks! Will bookmark that and
check there periodically instead.

Jason

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
  2020-03-19 18:01 [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files Jason A. Donenfeld
  2020-03-26  4:32 ` Jason A. Donenfeld
@ 2020-03-27  4:55 ` Herbert Xu
  2020-03-27  4:57   ` Jason A. Donenfeld
  1 sibling, 1 reply; 7+ messages in thread
From: Herbert Xu @ 2020-03-27  4:55 UTC (permalink / raw)
  To: Jason A. Donenfeld; +Cc: linux-crypto, Emil Renner Berthing, Ard Biesheuvel

On Thu, Mar 19, 2020 at 12:01:14PM -0600, Jason A. Donenfeld wrote:
> The .S_shipped yields a .S, and the pattern in these directories is to
> add that to .gitignore so that git-status doesn't raise a fuss.
> 
> Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Reported-by: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  arch/arm/crypto/.gitignore   | 1 +
>  arch/arm64/crypto/.gitignore | 1 +
>  2 files changed, 2 insertions(+)

Patch applied.

> diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
> index 879df8781ed5..e403b1343328 100644
> --- a/arch/arm64/crypto/.gitignore
> +++ b/arch/arm64/crypto/.gitignore
> @@ -1,2 +1,3 @@
>  sha256-core.S
>  sha512-core.S
> +poly1305-core.S

This didn't apply because a similar patch had already been added
to cryptodev a month ago.  Please base your patches on the latest
cryptodev in future.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
  2020-03-27  4:55 ` Herbert Xu
@ 2020-03-27  4:57   ` Jason A. Donenfeld
  2020-03-27 11:03     ` Herbert Xu
  0 siblings, 1 reply; 7+ messages in thread
From: Jason A. Donenfeld @ 2020-03-27  4:57 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Crypto Mailing List, Emil Renner Berthing, Ard Biesheuvel

On Thu, Mar 26, 2020 at 10:55 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Mar 19, 2020 at 12:01:14PM -0600, Jason A. Donenfeld wrote:
> > The .S_shipped yields a .S, and the pattern in these directories is to
> > add that to .gitignore so that git-status doesn't raise a fuss.
> >
> > Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > Reported-by: Emil Renner Berthing <kernel@esmil.dk>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> > ---
> >  arch/arm/crypto/.gitignore   | 1 +
> >  arch/arm64/crypto/.gitignore | 1 +
> >  2 files changed, 2 insertions(+)
>
> Patch applied.
>
> > diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
> > index 879df8781ed5..e403b1343328 100644
> > --- a/arch/arm64/crypto/.gitignore
> > +++ b/arch/arm64/crypto/.gitignore
> > @@ -1,2 +1,3 @@
> >  sha256-core.S
> >  sha512-core.S
> > +poly1305-core.S
>
> This didn't apply because a similar patch had already been added
> to cryptodev a month ago.  Please base your patches on the latest
> cryptodev in future.

I had sent this with [PATCH crypto] in the subject line, meant for
crypto-2.6.git for 5.6, since it's a bug fix for the things there. I
didn't realize you were queuing these changes for 5.7 instead.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files
  2020-03-27  4:57   ` Jason A. Donenfeld
@ 2020-03-27 11:03     ` Herbert Xu
  0 siblings, 0 replies; 7+ messages in thread
From: Herbert Xu @ 2020-03-27 11:03 UTC (permalink / raw)
  To: Jason A. Donenfeld
  Cc: Linux Crypto Mailing List, Emil Renner Berthing, Ard Biesheuvel

On Thu, Mar 26, 2020 at 10:57:50PM -0600, Jason A. Donenfeld wrote:
>
> I had sent this with [PATCH crypto] in the subject line, meant for
> crypto-2.6.git for 5.6, since it's a bug fix for the things there. I
> didn't realize you were queuing these changes for 5.7 instead.

Sorry about that.  However, as a general rule I don't take trivial
fixes such as these for the crypto tree.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 18:01 [PATCH crypto] crypto: arm[64]/poly1305 - add artifact to .gitignore files Jason A. Donenfeld
2020-03-26  4:32 ` Jason A. Donenfeld
2020-03-26  4:38   ` Herbert Xu
2020-03-26  4:39     ` Jason A. Donenfeld
2020-03-27  4:55 ` Herbert Xu
2020-03-27  4:57   ` Jason A. Donenfeld
2020-03-27 11:03     ` Herbert Xu

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git