From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Kamil Konieczny <k.konieczny@partner.samsung.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v4 3/3] crypto: s5p: add AES support for Exynos5433
Date: Tue, 5 Mar 2019 20:51:41 +0100 [thread overview]
Message-ID: <CAJKOXPdqf6b6LSxyhFJwoP+Jk+KCDvTtN1yM-LSP3n3kVt_nLQ@mail.gmail.com> (raw)
In-Reply-To: <20190305171303.GA29802@roeck-us.net>
On Tue, 5 Mar 2019 at 18:13, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Fri, Feb 22, 2019 at 01:21:44PM +0100, Kamil Konieczny wrote:
> > Add AES crypto HW acceleration for Exynos5433, with the help of SlimSSS IP.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> > ---
> > drivers/crypto/s5p-sss.c | 50 ++++++++++++++++++++++++++++++++++++----
> > 1 file changed, 46 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> > index 0064be0e3941..3f45cc5cb94a 100644
> > --- a/drivers/crypto/s5p-sss.c
> > +++ b/drivers/crypto/s5p-sss.c
> > @@ -232,6 +232,7 @@
> > * struct samsung_aes_variant - platform specific SSS driver data
> > * @aes_offset: AES register offset from SSS module's base.
> > * @hash_offset: HASH register offset from SSS module's base.
> > + * @clk_names: names of clocks needed to run SSS IP
> > *
> > * Specifies platform specific configuration of SSS module.
> > * Note: A structure for driver specific platform data is used for future
> > @@ -240,6 +241,7 @@
> > struct samsung_aes_variant {
> > unsigned int aes_offset;
> > unsigned int hash_offset;
> > + const char *clk_names[];
>
> This array does not have a fixed size.
Yes, correct. Kamil already sent a fix:
https://patchwork.kernel.org/patch/10835389/
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-03-05 19:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190222122203eucas1p1e87a8066d4348be4beb3ff035ea55828@eucas1p1.samsung.com>
2019-02-22 12:21 ` [PATCH v4 0/3] add AES support for Exynos5433 Kamil Konieczny
[not found] ` <CGME20190222122203eucas1p19a77c1cb72526ce36e99542926fd5a17@eucas1p1.samsung.com>
2019-02-22 12:21 ` [PATCH v4 1/3] arm64: dts: exynos: add SlimSSS " Kamil Konieczny
2019-03-20 19:58 ` Krzysztof Kozlowski
[not found] ` <CGME20190222122204eucas1p15e0e00e9b044d41d44c0d2e55cb6af9c@eucas1p1.samsung.com>
2019-02-22 12:21 ` [PATCH v4 2/3] dt-bindings: crypto: document Exynos5433 SlimSSS Kamil Konieczny
[not found] ` <CGME20190222122204eucas1p1ee66c9d937bdf328588ececb1f005526@eucas1p1.samsung.com>
2019-02-22 12:21 ` [PATCH v4 3/3] crypto: s5p: add AES support for Exynos5433 Kamil Konieczny
2019-03-01 9:56 ` Krzysztof Kozlowski
2019-03-01 10:07 ` Ard Biesheuvel
2019-03-01 10:12 ` Krzysztof Kozlowski
2019-03-05 17:13 ` Guenter Roeck
2019-03-05 19:51 ` Krzysztof Kozlowski [this message]
2019-03-06 17:31 ` Guenter Roeck
2019-02-28 6:36 ` [PATCH v4 0/3] " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPdqf6b6LSxyhFJwoP+Jk+KCDvTtN1yM-LSP3n3kVt_nLQ@mail.gmail.com \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=k.konieczny@partner.samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.szyprowski@samsung.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).