Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab'
@ 2019-08-09  8:29 YueHaibing
  2019-08-09 17:49 ` Ard Biesheuvel
  2019-08-15 12:07 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-08-09  8:29 UTC (permalink / raw)
  To: herbert, davem; +Cc: linux-kernel, linux-crypto, YueHaibing

crypto/aes_generic.c:64:18: warning:
 rco_tab defined but not used [-Wunused-const-variable=]

It is never used, so can be removed.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 crypto/aes_generic.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/crypto/aes_generic.c b/crypto/aes_generic.c
index 71a5c19..22e5867 100644
--- a/crypto/aes_generic.c
+++ b/crypto/aes_generic.c
@@ -61,8 +61,6 @@ static inline u8 byte(const u32 x, const unsigned n)
 	return x >> (n << 3);
 }
 
-static const u32 rco_tab[10] = { 1, 2, 4, 8, 16, 32, 64, 128, 27, 54 };
-
 /* cacheline-aligned to facilitate prefetching into cache */
 __visible const u32 crypto_ft_tab[4][256] ____cacheline_aligned = {
 	{
-- 
2.7.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab'
  2019-08-09  8:29 [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab' YueHaibing
@ 2019-08-09 17:49 ` Ard Biesheuvel
  2019-08-15 12:07 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-08-09 17:49 UTC (permalink / raw)
  To: YueHaibing
  Cc: Herbert Xu, David S. Miller, Linux Kernel Mailing List,
	open list:HARDWARE RANDOM NUMBER GENERATOR CORE

On Fri, 9 Aug 2019 at 11:30, YueHaibing <yuehaibing@huawei.com> wrote:
>
> crypto/aes_generic.c:64:18: warning:
>  rco_tab defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  crypto/aes_generic.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/crypto/aes_generic.c b/crypto/aes_generic.c
> index 71a5c19..22e5867 100644
> --- a/crypto/aes_generic.c
> +++ b/crypto/aes_generic.c
> @@ -61,8 +61,6 @@ static inline u8 byte(const u32 x, const unsigned n)
>         return x >> (n << 3);
>  }
>
> -static const u32 rco_tab[10] = { 1, 2, 4, 8, 16, 32, 64, 128, 27, 54 };
> -
>  /* cacheline-aligned to facilitate prefetching into cache */
>  __visible const u32 crypto_ft_tab[4][256] ____cacheline_aligned = {
>         {
> --
> 2.7.4
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab'
  2019-08-09  8:29 [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab' YueHaibing
  2019-08-09 17:49 ` Ard Biesheuvel
@ 2019-08-15 12:07 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-08-15 12:07 UTC (permalink / raw)
  To: YueHaibing; +Cc: davem, linux-kernel, linux-crypto

On Fri, Aug 09, 2019 at 04:29:19PM +0800, YueHaibing wrote:
> crypto/aes_generic.c:64:18: warning:
>  rco_tab defined but not used [-Wunused-const-variable=]
> 
> It is never used, so can be removed.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  crypto/aes_generic.c | 2 --
>  1 file changed, 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-09  8:29 [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab' YueHaibing
2019-08-09 17:49 ` Ard Biesheuvel
2019-08-15 12:07 ` Herbert Xu

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org linux-crypto@archiver.kernel.org
	public-inbox-index linux-crypto


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/ public-inbox